Skip to content

Commit b8e234c

Browse files
committed
fix(tooltip): account for sub pixel approximation in other browsers
1 parent 065594b commit b8e234c

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/Common/Tooltip/Tooltip.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import TippyJS from '@tippyjs/react'
1919
import { TooltipProps } from './types'
2020
import ShortcutKeyComboTooltipContent from './ShortcutKeyComboTooltipContent'
2121
import './styles.scss'
22+
import { SUB_PIXEL_ERROR } from './constants'
2223

2324
const Tooltip = ({
2425
shortcutKeyCombo,
@@ -33,7 +34,9 @@ const Tooltip = ({
3334

3435
const handleMouseEnterEvent: React.MouseEventHandler = (event) => {
3536
const { currentTarget: node } = event
36-
const isTextOverflowing = node.scrollWidth > node.clientWidth || node.scrollHeight > node.clientHeight
37+
const isTextOverflowing =
38+
node.scrollWidth > node.clientWidth + SUB_PIXEL_ERROR ||
39+
node.scrollHeight > node.clientHeight + SUB_PIXEL_ERROR
3740
if (isTextOverflowing && !isTextTruncated) {
3841
setIsTextTruncated(true)
3942
} else if (!isTextOverflowing && isTextTruncated) {

src/Common/Tooltip/constants.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,5 @@
1717
export const TOOLTIP_CONTENTS = {
1818
INVALID_INPUT: 'Valid input is required for all mandatory fields.',
1919
}
20+
21+
export const SUB_PIXEL_ERROR = 1

0 commit comments

Comments
 (0)