Merge pull request #433 from devtron-labs/fix/deployment-diff

eshankvaish · web-flow · commit b6ac6857c960 · 2024-12-03T21:32:44.000+05:30
fix: diff viewer title issue
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@devtron-labs/devtron-fe-common-lib",
-    "version": "1.1.8",
+    "version": "1.1.9",
     "description": "Supporting common component library",
     "type": "module",
     "main": "dist/index.js",
diff --git a/src/Shared/Components/DeploymentConfigDiff/DeploymentConfigDiffMain.tsx b/src/Shared/Components/DeploymentConfigDiff/DeploymentConfigDiffMain.tsx
@@ -194,8 +194,11 @@ export const DeploymentConfigDiffMain = ({
                         <DiffViewer
                             oldValue={primaryList.codeEditorValue.value}
                             newValue={secondaryList.codeEditorValue.value}
-                            leftTitle={primaryHeading}
-                            rightTitle={secondaryHeading}
+                            // Need to hide the title since the null state is controlled explicitly
+                            {...(primaryList.codeEditorValue.value !== secondaryList.codeEditorValue.value && {
+                                leftTitle: primaryHeading,
+                                rightTitle: secondaryHeading,
+                            })}
                             codeFoldMessageRenderer={renderDiffViewNoDifferenceState(
                                 primaryList.codeEditorValue.value,
                                 secondaryList.codeEditorValue.value,

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@devtron-labs/devtron-fe-common-lib",`
`3`		`- "version": "1.1.8",`
	`3`	`+ "version": "1.1.9",`
`4`	`4`	`"description": "Supporting common component library",`
`5`	`5`	`"type": "module",`
`6`	`6`	`"main": "dist/index.js",`