chore: extract type for categories

Author: arunjaindev

src/Shared/Components/Security/SecurityModal/config/Sidebar.ts

@@ -2,12 +2,11 @@
  * Copyright (c) 2024. Devtron Inc.
  */
 
+import { ScanCategoriesWithLicense } from '../../types'
 import { CATEGORY_LABELS, SUB_CATEGORY_LABELS } from '../constants'
 import { CATEGORIES, SUB_CATEGORIES, SidebarDataType } from '../types'
 
-export const getSidebarData = (
-    categoriesConfig: Record<(typeof CATEGORIES)[keyof typeof CATEGORIES] | 'imageScanLicenseRisks', boolean>,
-): SidebarDataType[] => {
+export const getSidebarData = (categoriesConfig: Record<ScanCategoriesWithLicense, boolean>): SidebarDataType[] => {
     const { imageScan, codeScan, kubernetesManifest, imageScanLicenseRisks } = categoriesConfig
 
     return [

src/Shared/Components/Security/SecurityModal/constants.tsx

@@ -14,6 +14,7 @@ import {
     StatusType,
     SecurityModalStateType,
 } from './types'
+import { ScanCategoriesWithLicense } from '../types'
 
 export const DEFAULT_SECURITY_MODAL_IMAGE_STATE = {
     category: CATEGORIES.IMAGE_SCAN,
@@ -34,7 +35,7 @@ const DEFAULT_SECURITY_MODAL_MANIFEST_STATE = {
 }
 
 export const getDefaultSecurityModalState = (
-    categoriesConfig: Record<(typeof CATEGORIES)[keyof typeof CATEGORIES] | 'imageScanLicenseRisks', boolean>,
+    categoriesConfig: Record<ScanCategoriesWithLicense, boolean>,
 ): SecurityModalStateType => {
     if (categoriesConfig.imageScan) {
         return DEFAULT_SECURITY_MODAL_IMAGE_STATE

src/Shared/Components/Security/SecurityModal/types.ts

@@ -7,6 +7,7 @@ import { GenericEmptyStateType } from '@Common/Types'
 import { LastExecutionResultType, NodeType, Nodes } from '@Shared/types'
 import { SegmentedBarChartProps } from '@Common/SegmentedBarChart'
 import { ServerErrors } from '@Common/ServerError'
+import { ScanCategories, ScanSubCategories } from '../types'
 
 export interface GetResourceScanDetailsPayloadType {
     name: string
@@ -100,8 +101,8 @@ export type DetailViewDataType = {
     InfoCardPropsType
 
 export type SecurityModalStateType = {
-    category: (typeof CATEGORIES)[keyof typeof CATEGORIES]
-    subCategory: (typeof SUB_CATEGORIES)[keyof typeof SUB_CATEGORIES]
+    category: ScanCategories
+    subCategory: ScanSubCategories
     detailViewData: DetailViewDataType[]
 }
 
@@ -264,8 +265,8 @@ export interface IndexedTextDisplayPropsType {
 export type SidebarDataChildType = {
     label: string
     value: {
-        category: (typeof CATEGORIES)[keyof typeof CATEGORIES]
-        subCategory: (typeof SUB_CATEGORIES)[keyof typeof SUB_CATEGORIES]
+        category: ScanCategories
+        subCategory: ScanSubCategories
     }
 }
 

src/Shared/Components/Security/types.tsx

@@ -3,6 +3,8 @@ import { CATEGORIES, SUB_CATEGORIES } from './SecurityModal/types'
 export type ScanCategories = (typeof CATEGORIES)[keyof typeof CATEGORIES]
 export type ScanSubCategories = (typeof SUB_CATEGORIES)[keyof typeof SUB_CATEGORIES]
 
+export type ScanCategoriesWithLicense = ScanCategories | 'imageScanLicenseRisks'
+
 export type CategoriesConfig = {
     imageScan: boolean
     codeScan: boolean