feat: use scan type from config in security card

Author: arunjaindev

src/Shared/Components/Security/SecurityDetailsCards/SecurityCard.tsx

@@ -3,10 +3,11 @@ import { ReactComponent as ICShieldWarning } from '@Icons/ic-shield-warning-outl
 import { ReactComponent as ICShieldSecure } from '@Icons/ic-shield-check.svg'
 import { ReactComponent as ICArrowRight } from '@Icons/ic-caret-down-small.svg'
 import { SecurityCardProps } from './types'
-import { CATEGORIES, SUB_CATEGORIES } from '../SecurityModal/types'
-import { CATEGORY_LABELS, SEVERITIES } from '../SecurityModal/constants'
+import { SUB_CATEGORIES } from '../SecurityModal/types'
+import { SEVERITIES } from '../SecurityModal/constants'
 import './securityCard.scss'
 import { getTotalSeverities } from '../utils'
+import { SECURITY_CONFIG } from '../constants'
 
 const SecurityCard = ({
     category,
@@ -26,17 +27,6 @@ const SecurityCard = ({
         }))
         .filter((entity) => !!entity.value)
 
-    const getScanType = () => {
-        switch (category) {
-            case CATEGORIES.KUBERNETES_MANIFEST:
-                return CATEGORY_LABELS.KUBERNETES_MANIFEST
-            case CATEGORIES.CODE_SCAN:
-                return CATEGORY_LABELS.CODE_SCAN
-            default:
-                return CATEGORY_LABELS.IMAGE_SCAN
-        }
-    }
-
     const getTitleSubtitle = (): { title: string; subtitle?: string } => {
         switch (subCategory) {
             case SUB_CATEGORIES.EXPOSED_SECRETS:
@@ -79,7 +69,7 @@ const SecurityCard = ({
         >
             <div className="flexbox dc__content-space">
                 <div className="flexbox-col">
-                    <span className="fs-12 fw-4 lh-1-5 cn-7">{getScanType()}</span>
+                    <span className="fs-12 fw-4 lh-1-5 cn-7">{SECURITY_CONFIG[category].label}</span>
                     <div className="fs-15 fw-6 lh-1-5 cn-9 flex">
                         <span className="security-card-title">{title}</span>
                         <ICArrowRight className="icon-dim-20 dc__flip-270 scb-5 arrow-right" />

src/Shared/Components/Security/SecurityDetailsCards/SecurityDetailsCards.tsx

@@ -59,34 +59,31 @@ const SecurityDetailsCards = ({ scanResult, Sidebar }: SecurityDetailsCardsProps
     return (
         <>
             <div className="flexbox-col dc__gap-20">
-                {Object.keys(SECURITY_CONFIG).map((category: ScanCategories) => {
-                    const scanToolId = getScanToolId(category)
-                    return (
-                        <div className="flexbox-col dc__gap-12" key={category}>
-                            <div className="flexbox dc__content-space pb-8 dc__border-bottom-n1">
-                                <span className="fs-13 fw-6 lh-1-5 cn-9">{SECURITY_CONFIG[category].label}</span>
-                                <ScannedByToolModal scanToolId={scanToolId} />
-                            </div>
-                            <div className="dc__grid security-cards">
-                                {SECURITY_CONFIG[category].subCategories.map((subCategory: ScanSubCategories) => {
-                                    const severityCount =
-                                        subCategory === SUB_CATEGORIES.MISCONFIGURATIONS
-                                            ? scanResult[category][subCategory]?.misConfSummary?.status
-                                            : scanResult[category][subCategory]?.summary?.severities
+                {Object.keys(SECURITY_CONFIG).map((category: ScanCategories) => (
+                    <div className="flexbox-col dc__gap-12" key={category}>
+                        <div className="flexbox dc__content-space pb-8 dc__border-bottom-n1">
+                            <span className="fs-13 fw-6 lh-1-5 cn-9">{SECURITY_CONFIG[category].label}</span>
+                            <ScannedByToolModal scanToolId={getScanToolId(category)} />
+                        </div>
+                        <div className="dc__grid security-cards">
+                            {SECURITY_CONFIG[category].subCategories.map((subCategory: ScanSubCategories) => {
+                                const severityCount =
+                                    subCategory === SUB_CATEGORIES.MISCONFIGURATIONS
+                                        ? scanResult[category][subCategory]?.misConfSummary?.status
+                                        : scanResult[category][subCategory]?.summary?.severities
 
-                                    return (
-                                        <SecurityCard
-                                            category={category}
-                                            subCategory={subCategory}
-                                            severityCount={severityCount}
-                                            handleCardClick={handleCardClick(category, subCategory)}
-                                        />
-                                    )
-                                })}
-                            </div>
+                                return (
+                                    <SecurityCard
+                                        category={category}
+                                        subCategory={subCategory}
+                                        severityCount={severityCount}
+                                        handleCardClick={handleCardClick(category, subCategory)}
+                                    />
+                                )
+                            })}
                         </div>
-                    )
-                })}
+                    </div>
+                ))}
             </div>
             {showSecurityModal && (
                 <SecurityModal

src/Shared/Components/Security/utils.tsx

@@ -17,13 +17,13 @@ export const getSecurityConfig = ({
     kubernetesManifest,
 }: CategoriesConfig): SecurityConfigType => ({
     ...(imageScan && {
-        [CATEGORIES.IMAGE_SCAN]: SECURITY_CONFIG.imageScan,
+        [CATEGORIES.IMAGE_SCAN]: SECURITY_CONFIG[CATEGORIES.IMAGE_SCAN],
     }),
     ...(codeScan && {
-        [CATEGORIES.CODE_SCAN]: SECURITY_CONFIG.codeScan,
+        [CATEGORIES.CODE_SCAN]: SECURITY_CONFIG[CATEGORIES.CODE_SCAN],
     }),
     ...(kubernetesManifest && {
-        [CATEGORIES.KUBERNETES_MANIFEST]: SECURITY_CONFIG.kubernetesManifest,
+        [CATEGORIES.KUBERNETES_MANIFEST]: SECURITY_CONFIG[CATEGORIES.KUBERNETES_MANIFEST],
     }),
 })