Skip to content

Commit b2a78b3

Browse files
committed
refactor: code clean up
1 parent 4c2b2af commit b2a78b3

File tree

2 files changed

+6
-15
lines changed

2 files changed

+6
-15
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
export const DEFAULT_MINIMUM_HEADER_WIDTH = 70
2+
3+
export const DEFAULT_MAXIMUM_HEADER_WIDTH = 600

src/Common/SortableTableHeaderCell/useResizableTableConfig.tsx

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { useEffect, useState } from 'react'
22
import { UseResizableTableConfigProps } from './types'
3+
import { DEFAULT_MAXIMUM_HEADER_WIDTH, DEFAULT_MINIMUM_HEADER_WIDTH } from './constants'
34

45
const useResizableTableConfig = ({ headersConfig }: UseResizableTableConfigProps) => {
56
const [headerDimensionsConfig, setHeaderDimensionsConfig] = useState<
@@ -31,8 +32,8 @@ const useResizableTableConfig = ({ headersConfig }: UseResizableTableConfigProps
3132
const currentHeaderCellConfig = headersConfig[headerCellIndexInConfig]
3233

3334
if (
34-
updatedCellDimension < (currentHeaderCellConfig.minWidth ?? 70) ||
35-
updatedCellDimension > (currentHeaderCellConfig.maxWidth ?? 600)
35+
updatedCellDimension < (currentHeaderCellConfig.minWidth ?? DEFAULT_MINIMUM_HEADER_WIDTH) ||
36+
updatedCellDimension > (currentHeaderCellConfig.maxWidth ?? DEFAULT_MAXIMUM_HEADER_WIDTH)
3637
) {
3738
return prev
3839
}
@@ -42,24 +43,11 @@ const useResizableTableConfig = ({ headersConfig }: UseResizableTableConfigProps
4243
})
4344
}
4445

45-
const register = (headerCellId: UseResizableTableConfigProps['headersConfig'][number]['id']) => {
46-
const sortableTableHeaderCellConfig = headersConfig.find((config) => config.id === headerCellId)
47-
48-
if (!sortableTableHeaderCellConfig) {
49-
return null
50-
}
51-
52-
return {
53-
id: sortableTableHeaderCellConfig.id,
54-
}
55-
}
56-
5746
return {
5847
gridTemplateColumns: headerDimensionsConfig
5948
.map((config) => (typeof config === 'number' ? `${config}px` : config))
6049
.join(' '),
6150
handleResize,
62-
register,
6351
}
6452
}
6553

0 commit comments

Comments
 (0)