fix: code feedback

eshankvaish · eshankvaish · commit a5fc91c9461e · 2024-12-06T11:30:59.000+05:30
diff --git a/src/Common/Common.service.ts b/src/Common/Common.service.ts
@@ -197,7 +197,7 @@ const sanitizeDeploymentApprovalInfo = (
             approverList: sanitizeUserApprovalList(deploymentApprovalInfo?.eligibleApprovers?.anyUsers?.approverList),
         },
         specificUsers: {
-            approverList: sanitizeUserApprovalList(deploymentApprovalInfo?.eligibleApprovers?.anyUsers?.approverList),
+            approverList: sanitizeUserApprovalList(deploymentApprovalInfo?.eligibleApprovers?.specificUsers?.approverList),
         },
         userGroups: (deploymentApprovalInfo?.eligibleApprovers?.userGroups ?? []).map(
             ({ groupName, groupIdentifier, approverList }) => ({
diff --git a/src/Common/Types.ts b/src/Common/Types.ts
@@ -374,9 +374,10 @@ export interface UserApprovalInfo {
 }
 
 export enum ApprovalConfigDataKindType {
-    configMap = 'CM',
-    configSecret = 'CS',
-    deploymentTemplate = 'DEPLOYMENT_TEMPLATE',
+    configMap = 'configuration/config-map',
+    configSecret = 'configuration/config-secret',
+    deploymentTemplate = 'configuration/deployment-template',
+    deploymentTrigger = 'approval/deployment',
 }
 
 export interface ApprovalConfigDataType extends Pick<UserApprovalInfo, 'currentCount' | 'requiredCount'> {

Original file line number	Diff line number	Diff line change
`@@ -374,9 +374,10 @@ export interface UserApprovalInfo {`
`374`	`374`	`}`
`375`	`375`
`376`	`376`	`export enum ApprovalConfigDataKindType {`
`377`		`- configMap = 'CM',`
`378`		`- configSecret = 'CS',`
`379`		`- deploymentTemplate = 'DEPLOYMENT_TEMPLATE',`
	`377`	`+ configMap = 'configuration/config-map',`
	`378`	`+ configSecret = 'configuration/config-secret',`
	`379`	`+ deploymentTemplate = 'configuration/deployment-template',`
	`380`	`+ deploymentTrigger = 'approval/deployment',`
`380`	`381`	`}`
`381`	`382`
`382`	`383`	`export interface ApprovalConfigDataType extends Pick<UserApprovalInfo, 'currentCount' \| 'requiredCount'> {`