Merge branch 'develop' of github.com:devtron-labs/devtron-fe-common-lib into refactor/rb-tabs

Author: eshankvaish

package-lock.json

@@ -1,6 +1,6 @@
 {
     "name": "@devtron-labs/devtron-fe-common-lib",
-    "version": "1.0.4-beta-5",
+    "version": "1.0.6",
     "description": "Supporting common component library",
     "type": "module",
     "main": "dist/index.js",

package.json

@@ -163,7 +163,7 @@ const useUrlFilters = <T = string, K = unknown>({
     useEffect(() => {
         // if we have search string, set secondary params in local storage accordingly
         if (location.search) {
-            localStorage.setItem(localStorageKey, JSON.stringify(parsedParams))
+            setItemInLocalStorageIfKeyExists(localStorageKey, JSON.stringify(parsedParams))
             return
         }
         const localStorageValue = localStorage.getItem(localStorageKey)

src/Common/Hooks/useUrlFilters/useUrlFilters.ts

@@ -95,7 +95,7 @@ export type ProcessPluginDataParamsType = {
     /**
      * Would be sent in case we have to get data for steps
      */
-    requiredPluginIds?: PluginDetailPayloadType['pluginId']
+    requiredPluginIds?: PluginDetailPayloadType['pluginIds']
 } & (ProcessPluginDataCIParamsType | ProcessPluginDataCDParamsType)
 
 export enum ConsequenceAction {

src/Common/Policy.Types.ts

@@ -14,7 +14,15 @@
  * limitations under the License.
  */
 
-import { get, getIsRequestAborted, getUrlWithSearchParams, ResponseType, ROUTES, showError } from '../../../Common'
+import {
+    get,
+    getIsRequestAborted,
+    getUrlWithSearchParams,
+    post,
+    ResponseType,
+    ROUTES,
+    showError,
+} from '../../../Common'
 import { stringComparatorBySortOrder } from '../../Helpers'
 import {
     GetParentPluginListPayloadType,
@@ -41,13 +49,14 @@ export const getPluginsDetail = async ({
     try {
         const payload: PluginDetailPayloadType = {
             appId,
-            parentPluginId: parentPluginIds,
-            pluginId: pluginIds,
-            parentPluginIdentifier: parentPluginIdentifiers ? `${parentPluginIdentifiers}` : null,
+            parentPluginIds,
+            pluginIds,
+            parentPluginIdentifiers,
         }
 
-        const { result } = await get<PluginDetailDTO>(
-            getUrlWithSearchParams(ROUTES.PLUGIN_GLOBAL_LIST_DETAIL_V2, payload),
+        const { result } = await post<PluginDetailDTO, PluginDetailPayloadType>(
+            ROUTES.PLUGIN_GLOBAL_LIST_DETAIL_V2,
+            payload,
             { signal },
         )
 

src/Shared/Components/Plugin/service.tsx

@@ -94,11 +94,11 @@ export interface PluginDetailServiceParamsType {
     signal?: AbortSignal
 }
 
-export interface PluginDetailPayloadType extends Pick<PluginDetailServiceParamsType, 'appId'> {
-    pluginId?: PluginDetailServiceParamsType['pluginIds']
-    parentPluginId?: PluginDetailServiceParamsType['parentPluginIds']
-    parentPluginIdentifier?: PluginDetailServiceParamsType['parentPluginIdentifiers'][number]
-}
+export interface PluginDetailPayloadType
+    extends Pick<
+        PluginDetailServiceParamsType,
+        'appId' | 'parentPluginIds' | 'pluginIds' | 'parentPluginIdentifiers'
+    > {}
 
 export interface PluginListFiltersType extends Pick<BaseFilterQueryParams<unknown>, 'searchKey'> {
     selectedTags: string[]