Merge pull request #403 from devtron-labs/fix/external-secrets

eshankvaish · web-flow · commit 8d6bdb3629bd · 2024-11-13T16:14:11.000+05:30
fix: hide config diff for external secret
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@devtron-labs/devtron-fe-common-lib",
-    "version": "0.6.5",
+    "version": "0.6.5-patch-1",
     "description": "Supporting common component library",
     "type": "module",
     "main": "dist/index.js",
diff --git a/src/Shared/Components/DeploymentConfigDiff/DeploymentConfigDiff.utils.tsx b/src/Shared/Components/DeploymentConfigDiff/DeploymentConfigDiff.utils.tsx
@@ -232,8 +232,8 @@ const getCodeEditorData = (
         const { compareToObfuscatedData, compareWithObfuscatedData } = getObfuscatedData(
             compareToConfigData ?? {},
             compareWithConfigData ?? {},
-            compareToIsAdmin,
-            compareWithIsAdmin,
+            compareToIsAdmin || compareToValue?.external,
+            compareWithIsAdmin || compareWithValue?.external,
         )
 
         compareToCodeEditorData = {

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@devtron-labs/devtron-fe-common-lib",`
`3`		`- "version": "0.6.5",`
	`3`	`+ "version": "0.6.5-patch-1",`
`4`	`4`	`"description": "Supporting common component library",`
`5`	`5`	`"type": "module",`
`6`	`6`	`"main": "dist/index.js",`