Skip to content

Commit 894223b

Browse files
committed
fix: dot shortcut & null checks in Table
1 parent de76c38 commit 894223b

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/Common/Hooks/UseRegisterShortcut/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export const KEYBOARD_KEYS_MAP = {
3939
End: 'End',
4040
Backspace: '⌫',
4141
Delete: '⌦',
42-
Dot: '.',
42+
'.': '.',
4343
Space: 'Space',
4444
} as const
4545

src/Shared/Components/Table/Table.component.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ const InternalTable = ({
347347
}
348348

349349
const renderContent = () => {
350-
if (!areFilteredRowsLoading && !filteredRows.length) {
350+
if (!areFilteredRowsLoading && !filteredRows?.length) {
351351
return filtersVariant !== FiltersTypeEnum.NONE && isFilterApplied ? (
352352
<GenericFilterEmptyState handleClearFilters={clearFilters} />
353353
) : (
@@ -536,7 +536,7 @@ const TableWithKeyboardShortcuts = (tableProps: InternalTablePropsWithWrappers)
536536
})
537537

538538
registerShortcut({
539-
keys: ['Dot'],
539+
keys: ['.'],
540540
callback: () => {
541541
dispatchEvent(SignalEnum.OPEN_CONTEXT_MENU)
542542
},
@@ -598,7 +598,7 @@ const TableWithKeyboardShortcuts = (tableProps: InternalTablePropsWithWrappers)
598598
unregisterShortcut(['ArrowUp'])
599599
unregisterShortcut(['ArrowDown'])
600600
unregisterShortcut(['Enter'])
601-
unregisterShortcut(['Dot'])
601+
unregisterShortcut(['.'])
602602
unregisterShortcut(['Delete'])
603603

604604
if (isBulkSelectionConfigured) {
@@ -724,7 +724,7 @@ const TableWrapper = (tableProps: TableProps) => {
724724
const wrapperProps = FilterWrapperComponent === Fragment ? {} : { additionalFilterProps }
725725

726726
return (
727-
<UseRegisterShortcutProvider shortcutTimeout={50} preventDefault>
727+
<UseRegisterShortcutProvider shortcutTimeout={50}>
728728
<FilterWrapperComponent {...wrapperProps}>
729729
{/* NOTE: filterData will be populated by FilterWrapperComponent */}
730730
<VisibleColumnsWrapper

0 commit comments

Comments
 (0)