Skip to content

Commit 87a03b1

Browse files
committed
refactor: CIPipeline - types update, DynamicDataTableRow - css update
1 parent 3af95d8 commit 87a03b1

File tree

2 files changed

+25
-4
lines changed

2 files changed

+25
-4
lines changed

src/Common/CIPipeline.Types.ts

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414
* limitations under the License.
1515
*/
1616

17+
import { DynamicDataTableCellValidationState } from '@Shared/Components'
18+
1719
export interface MaterialType {
1820
name: string
1921
type: string
@@ -289,11 +291,30 @@ export interface ErrorObj {
289291
isValid: boolean
290292
message: string | null
291293
}
294+
295+
export enum InputOutputVariablesHeaderKeys {
296+
VARIABLE = 'variable',
297+
FORMAT = 'format',
298+
VALUE = 'val',
299+
}
300+
301+
export type InputOutputVariablesErrorObj = Record<InputOutputVariablesHeaderKeys, DynamicDataTableCellValidationState>
302+
292303
export interface TaskErrorObj {
293304
isValid: boolean
294305
name: ErrorObj
295-
inlineStepDetail?: { inputVariables?: ErrorObj[]; outputVariables?: ErrorObj[]; isValid?: boolean }
296-
pluginRefStepDetail?: { inputVariables?: ErrorObj[]; outputVariables?: ErrorObj[]; isValid?: boolean }
306+
inlineStepDetail?: {
307+
inputVariables?: Record<number, InputOutputVariablesErrorObj>
308+
outputVariables?: Record<number, InputOutputVariablesErrorObj>
309+
isInputVariablesValid?: boolean
310+
isOutputVariablesValid?: boolean
311+
}
312+
pluginRefStepDetail?: {
313+
inputVariables?: Record<number, InputOutputVariablesErrorObj>
314+
outputVariables?: Record<number, InputOutputVariablesErrorObj>
315+
isInputVariablesValid?: boolean
316+
isOutputVariablesValid?: boolean
317+
}
297318
}
298319
export interface FormErrorObjectType {
299320
name: ErrorObj

src/Shared/Components/DynamicDataTable/DynamicDataTableRow.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ export const DynamicDataTableRow = <K extends string, CustomStateType = Record<s
156156
}}
157157
textAreaProps={{
158158
...row.data[key].props?.textAreaProps,
159-
className: 'dynamic-data-table__cell-input placeholder-cn5 py-8 pr-8 cn-9 fs-13 lh-20',
159+
className: 'dynamic-data-table__cell-input placeholder-cn5 py-8 pr-32 cn-9 fs-13 lh-20',
160160
disableOnBlurResizeToMinHeight: true,
161161
minHeight: 20,
162162
maxHeight: 160,
@@ -183,7 +183,7 @@ export const DynamicDataTableRow = <K extends string, CustomStateType = Record<s
183183
)
184184
case DynamicDataTableRowDataType.FILE_UPLOAD:
185185
return (
186-
<div className={`w-100 h-100 flex top left px-8 ${row.data[key].value ? 'py-3' : 'py-8'}`}>
186+
<div className={`mw-none w-100 h-100 flex top left px-8 ${row.data[key].value ? 'py-3' : 'py-8'}`}>
187187
<FileUpload
188188
{...row.data[key].props}
189189
fileName={row.data[key].value}

0 commit comments

Comments
 (0)