Merge pull request #408 from devtron-labs/fix/persist-url-filters

arunjaindev · web-flow · commit 86bad54bcabc · 2024-11-19T16:29:43.000+05:30
fix: do not set in local storage for undefined
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@devtron-labs/devtron-fe-common-lib",
-    "version": "1.0.9",
+    "version": "1.0.10",
     "description": "Supporting common component library",
     "type": "module",
     "main": "dist/index.js",
diff --git a/src/Common/Hooks/useUrlFilters/useUrlFilters.ts b/src/Common/Hooks/useUrlFilters/useUrlFilters.ts
@@ -161,6 +161,9 @@ const useUrlFilters = <T = string, K = unknown>({
     }
 
     useEffect(() => {
+        if (!localStorageKey) {
+            return
+        }
         // if we have search string, set secondary params in local storage accordingly
         if (location.search) {
             setItemInLocalStorageIfKeyExists(localStorageKey, JSON.stringify(parsedParams))

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@devtron-labs/devtron-fe-common-lib",`
`3`		`- "version": "1.0.9",`
	`3`	`+ "version": "1.0.10",`
`4`	`4`	`"description": "Supporting common component library",`
`5`	`5`	`"type": "module",`
`6`	`6`	`"main": "dist/index.js",`
Original file line number	Diff line number	Diff line change
`@@ -161,6 +161,9 @@ const useUrlFilters = <T = string, K = unknown>({`
`161`	`161`	`}`
`162`	`162`
`163`	`163`	`useEffect(() => {`
	`164`	`+ if (!localStorageKey) {`
	`165`	`+ return`
	`166`	`+ }`
`164`	`167`	`// if we have search string, set secondary params in local storage accordingly`
`165`	`168`	`if (location.search) {`
`166`	`169`	`setItemInLocalStorageIfKeyExists(localStorageKey, JSON.stringify(parsedParams))`