Skip to content

Commit 7fa7c13

Browse files
committed
feat: DeploymentDetailSteps - virtual environment - show deployed by exception user
1 parent c400d9b commit 7fa7c13

File tree

5 files changed

+24
-19
lines changed

5 files changed

+24
-19
lines changed

src/Shared/Components/CICDHistory/Artifacts.tsx

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ import {
3636
useGetUserRoles,
3737
} from '../../../Common'
3838
import { EMPTY_STATE_STATUS } from '../../constants'
39-
import { Icon } from '../Icon'
4039
import { TargetPlatformBadgeList } from '../TargetPlatforms'
4140
import { TERMINAL_STATUS_MAP } from './constants'
4241
import { ArtifactType, CIListItemType } from './types'
@@ -75,6 +74,8 @@ export const CIListItem = ({
7574
!!appliedFilters?.length ||
7675
!!promotionApprovalMetadata?.promotedFromType
7776

77+
const showCIListHeader = (headerMetaDataPresent || isDeploymentWithoutApproval) && !!renderCIListHeader
78+
7879
return (
7980
<>
8081
{type === 'deployed-artifact' && (
@@ -85,29 +86,20 @@ export const CIListItem = ({
8586
</div>
8687
)}
8788

88-
{isDeploymentWithoutApproval && (
89-
<div className="w-100 bg__primary flex left dc__gap-6 px-12 pt-8 pb-7 border__secondary--bottom border__primary--top border__primary--left border__primary--right dc__top-radius-4">
90-
<Icon name="ic-lightning-fill" color="Y500" />
91-
<p className="m-0 fs-13 lh-20 cn-9">Deployed by an exception user</p>
92-
</div>
93-
)}
94-
95-
{headerMetaDataPresent &&
96-
renderCIListHeader &&
89+
{showCIListHeader &&
9790
renderCIListHeader({
9891
userApprovalMetadata,
9992
triggeredBy,
10093
appliedFilters,
10194
appliedFiltersTimestamp,
10295
promotionApprovalMetadata,
10396
selectedEnvironmentName,
97+
isDeploymentWithoutApproval,
10498
})}
10599

106100
<div
107101
className={`dc__h-fit-content ci-artifact image-tag-parent-card bg__primary br-4 dc__border p-12 w-100 dc__mxw-800 ci-artifact--${type} ${
108-
(headerMetaDataPresent && renderCIListHeader) || isDeploymentWithoutApproval
109-
? 'dc__no-top-radius dc__no-top-border'
110-
: ''
102+
showCIListHeader ? 'dc__no-top-radius dc__no-top-border' : ''
111103
}`}
112104
data-testid="hover-on-report-artifact"
113105
>

src/Shared/Components/CICDHistory/DeploymentDetailSteps.tsx

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ const DeploymentDetailSteps = ({
4343
isVirtualEnvironment,
4444
processVirtualEnvironmentDeploymentData,
4545
renderDeploymentApprovalInfo,
46+
isDeploymentWithoutApproval,
4647
}: DeploymentDetailStepsType) => {
4748
const history = useHistory()
4849
const { url } = useRouteMatch()
@@ -51,6 +52,8 @@ const DeploymentDetailSteps = ({
5152
deploymentStatus?.toUpperCase() !== TIMELINE_STATUS.ABORTED,
5253
)
5354
const isVirtualEnv = useRef(isVirtualEnvironment)
55+
const isDeploymentWithoutApprovalRef = useRef(isDeploymentWithoutApproval)
56+
5457
const processedData =
5558
isVirtualEnv.current && processVirtualEnvironmentDeploymentData
5659
? processVirtualEnvironmentDeploymentData()
@@ -69,7 +72,10 @@ const DeploymentDetailSteps = ({
6972
.then((deploymentStatusDetailRes) => {
7073
if (deploymentStatus !== 'Aborted') {
7174
// eslint-disable-next-line no-use-before-define
72-
processDeploymentStatusData(deploymentStatusDetailRes.result)
75+
processDeploymentStatusData({
76+
...deploymentStatusDetailRes.result,
77+
isDeploymentWithoutApproval: isDeploymentWithoutApprovalRef.current,
78+
})
7379
}
7480
})
7581
.catch(() => {
@@ -97,6 +103,10 @@ const DeploymentDetailSteps = ({
97103
isVirtualEnv.current = isVirtualEnvironment
98104
}, [isVirtualEnvironment])
99105

106+
useEffect(() => {
107+
isDeploymentWithoutApprovalRef.current = isDeploymentWithoutApproval
108+
}, [isDeploymentWithoutApproval])
109+
100110
const processDeploymentStatusData = (deploymentStatusDetailRes: DeploymentStatusDetailsType): void => {
101111
const processedDeploymentStatusDetailsData =
102112
isVirtualEnv.current && processVirtualEnvironmentDeploymentData

src/Shared/Components/CICDHistory/DeploymentStatusDetailRow.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,9 @@ export const DeploymentStatusDetailRow = ({
176176
>
177177
{renderIcon(statusBreakDownType.icon)}
178178
<span className="ml-12 mr-12 fs-13">
179-
<span data-testid="deployment-status-step-name">{statusBreakDownType.displayText}</span>
179+
<span data-testid="deployment-status-step-name" className="flex left">
180+
{statusBreakDownType.displayText}
181+
</span>
180182
{statusBreakDownType.displaySubText && (
181183
<span className={`ml-12 f-${statusBreakDownType.icon || 'waiting'}`}>
182184
{statusBreakDownType.displaySubText}

src/Shared/Components/CICDHistory/TriggerOutput.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,7 @@ const HistoryLogs: React.FC<HistoryLogsProps> = ({
133133
isVirtualEnvironment={triggerDetails.IsVirtualEnvironment}
134134
processVirtualEnvironmentDeploymentData={processVirtualEnvironmentDeploymentData}
135135
renderDeploymentApprovalInfo={renderDeploymentApprovalInfo}
136+
isDeploymentWithoutApproval={triggerDetails.isDeploymentWithoutApproval ?? false}
136137
/>
137138
</Route>
138139
)}

src/Shared/Components/CICDHistory/types.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ export interface DeploymentStatusDetailsTimelineType {
390390
statusTime: string
391391
resourceDetails?: SyncStageResourceDetail[]
392392
}
393-
export interface DeploymentStatusDetailsType {
393+
export interface DeploymentStatusDetailsType extends Pick<History, 'isDeploymentWithoutApproval'> {
394394
deploymentFinishedOn: string
395395
deploymentStartedOn: string
396396
triggeredBy: string
@@ -406,7 +406,7 @@ export interface DeploymentStatusDetailsResponse extends ResponseType {
406406

407407
interface DeploymentStatusDetailRow {
408408
icon: string
409-
displayText: string
409+
displayText: ReactNode
410410
displaySubText: string
411411
time: string
412412
resourceDetails?: any
@@ -432,7 +432,7 @@ export interface DeploymentStatusDetailsBreakdownDataType {
432432
}
433433
}
434434

435-
export interface DeploymentDetailStepsType {
435+
export interface DeploymentDetailStepsType extends Pick<History, 'isDeploymentWithoutApproval'> {
436436
deploymentStatus?: string
437437
deploymentAppType?: DeploymentAppTypes
438438
isHelmApps?: boolean
@@ -446,7 +446,7 @@ export interface DeploymentDetailStepsType {
446446
renderDeploymentApprovalInfo: (userApprovalMetadata: UserApprovalMetadataType) => JSX.Element
447447
}
448448

449-
export interface RenderCIListHeaderProps {
449+
export interface RenderCIListHeaderProps extends Required<Pick<History, 'isDeploymentWithoutApproval'>> {
450450
userApprovalMetadata: UserApprovalMetadataType
451451
triggeredBy: string
452452
appliedFilters: FilterConditionsListType[]

0 commit comments

Comments
 (0)