fix/posthog-event

Author: shivani170

src/Shared/Components/GettingStartedCard/GettingStarted.tsx

@@ -24,20 +24,20 @@ import './gettingStarted.scss'
 import { Button, ButtonStyleType, ButtonVariantType } from '../Button'
 
 const GettingStartedCard = ({ className, hideGettingStartedCard }: GettingStartedType) => {
-    const onClickedOkay = async (e) => {
+    const onClickedOkay = async () => {
         setActionWithExpiry('clickedOkay', 1)
         hideGettingStartedCard()
-        await handlePostHogEventUpdate(e)
+        await handlePostHogEventUpdate(POSTHOG_EVENT_ONBOARDING.TOOLTIP_OKAY)
     }
 
-    const onClickedDontShowAgain = async (e) => {
+    const onClickedDontShowAgain = async () => {
         const updatedPayload = {
             key: LOGIN_COUNT,
             value: `${MAX_LOGIN_COUNT}`,
         }
         await updateLoginCount(updatedPayload)
         hideGettingStartedCard(updatedPayload.value)
-        await handlePostHogEventUpdate(e)
+        await handlePostHogEventUpdate(POSTHOG_EVENT_ONBOARDING.TOOLTIP_DONT_SHOW_AGAIN)
     }
 
     return (
@@ -53,15 +53,13 @@ const GettingStartedCard = ({ className, hideGettingStartedCard }: GettingStarte
                         size={ComponentSizeType.xs}
                         dataTestId="getting-started-okay"
                         onClick={onClickedOkay}
-                        data-posthog={POSTHOG_EVENT_ONBOARDING.TOOLTIP_OKAY}
                     />
                     <Button
                         text="Don't show again"
                         size={ComponentSizeType.xs}
                         dataTestId="getting-started-don't-show-again"
                         onClick={onClickedDontShowAgain}
                         style={ButtonStyleType.neutral}
-                        data-posthog={POSTHOG_EVENT_ONBOARDING.TOOLTIP_DONT_SHOW_AGAIN}
                         variant={ButtonVariantType.secondary}
                     />
                 </div>

src/Shared/Components/Header/PageHeader.tsx

@@ -100,7 +100,7 @@ const PageHeader = ({
         hideGettingStartedCard()
     }
 
-    const onClickHelp = async (e) => {
+    const onClickHelp = async () => {
         if (
             !window._env_.K8S_CLIENT &&
             currentServerInfo.serverInfo?.installationType !== InstallationType.ENTERPRISE
@@ -113,7 +113,7 @@ const PageHeader = ({
         }
         setActionWithExpiry('clickedOkay', 1)
         hideGettingStartedCard()
-        await handlePostHogEventUpdate(e, POSTHOG_EVENT_ONBOARDING.HELP)
+        await handlePostHogEventUpdate(POSTHOG_EVENT_ONBOARDING.HELP)
         ReactGA.event({
             category: 'Main Navigation',
             action: `Help Clicked`,

src/Shared/Components/Header/index.ts

@@ -16,3 +16,4 @@
 
 export { default as PageHeader } from './PageHeader'
 export * from './HeaderWithCreateButton'
+export * from './utils'

src/Shared/Components/Header/utils.ts

@@ -20,9 +20,9 @@ import { LOGIN_COUNT } from '../../../Common'
 const millisecondsInDay = 86400000
 export const getDateInMilliseconds = (days) => 1 + new Date().valueOf() + (days ?? 0) * millisecondsInDay
 
-export const handlePostHogEventUpdate = async (e, eventName?: string): Promise<void> => {
+export const handlePostHogEventUpdate = async (eventName?: string): Promise<void> => {
     const payload = {
-        eventType: eventName || e.target?.dataset.posthog,
+        eventType: eventName,
         key: LOGIN_COUNT,
         value: '',
         active: true,