fix: review comments

Author: Elessar1802

src/Common/Helper.tsx

@@ -23,10 +23,23 @@ import moment from 'moment'
 import { useLocation } from 'react-router-dom'
 import YAML from 'yaml'
 import { deepEquals } from '@rjsf/utils'
-import { ERROR_EMPTY_SCREEN, SortingOrder, EXCLUDED_FALSY_VALUES, DISCORD_LINK, ZERO_TIME_STRING, TOAST_ACCESS_DENIED } from './Constants'
+import {
+    ERROR_EMPTY_SCREEN,
+    SortingOrder,
+    EXCLUDED_FALSY_VALUES,
+    DISCORD_LINK,
+    ZERO_TIME_STRING,
+    TOAST_ACCESS_DENIED,
+} from './Constants'
 import { ServerErrors } from './ServerError'
 import { AsyncOptions, AsyncState, UseSearchString } from './Types'
-import { scrollableInterface, DATE_TIME_FORMAT_STRING, ToastManager, ToastVariantType, versionComparatorBySortOrder } from '../Shared'
+import {
+    scrollableInterface,
+    DATE_TIME_FORMAT_STRING,
+    ToastManager,
+    ToastVariantType,
+    versionComparatorBySortOrder,
+} from '../Shared'
 import { ReactComponent as ArrowDown } from '../Assets/Icon/ic-chevron-down.svg'
 
 export function showError(serverError, showToastOnUnknownError = true, hideAccessError = false) {

src/Common/RJSF/utils.tsx

@@ -137,7 +137,10 @@ export const getInferredTypeFromValueType = (value) => {
     }
 }
 
-const conformPathToPointers = (path: string) => {
+const conformPathToPointers = (path: string): string => {
+    if (!path) {
+        return ''
+    }
     const trimmedPath = path.trim()
     const isSlashSeparatedPathMissingBeginSlash = trimmedPath.match(/^\w+(\/\w+)*$/g)
     if (isSlashSeparatedPathMissingBeginSlash) {
@@ -151,6 +154,11 @@ const conformPathToPointers = (path: string) => {
     return trimmedPath
 }
 
+const emptyMetaHiddenTypeInstance: MetaHiddenType = {
+    value: false,
+    path: '',
+}
+
 export const parseSchemaHiddenType = (hiddenSchema: HiddenType): MetaHiddenType => {
     if (!hiddenSchema) {
         return null
@@ -162,14 +170,20 @@ export const parseSchemaHiddenType = (hiddenSchema: HiddenType): MetaHiddenType
             path: conformPathToPointers(clone),
         }
     }
-    if ('condition' in clone) {
+    if (typeof clone !== 'object') {
+        return structuredClone(emptyMetaHiddenTypeInstance)
+    }
+    if ('condition' in clone && 'value' in clone) {
         return {
             value: clone.condition,
             path: conformPathToPointers(clone.value),
         }
     }
-    return {
-        ...clone,
-        path: conformPathToPointers(clone.path),
+    if ('value' in clone && 'path' in clone) {
+        return {
+            value: clone.value,
+            path: conformPathToPointers(clone.path),
+        }
     }
+    return structuredClone(emptyMetaHiddenTypeInstance)
 }

src/Shared/Helpers.tsx

@@ -141,10 +141,10 @@ export const numberComparatorBySortOrder = (
 
 export function versionComparatorBySortOrder(a: string, b: string, orderBy = SortingOrder.ASC) {
     if (orderBy === SortingOrder.DESC) {
-        return a.localeCompare(b, undefined, { numeric: true })
+        return a?.localeCompare(b, undefined, { numeric: true }) ?? 1
     }
 
-    return b.localeCompare(a, undefined, { numeric: true })
+    return b?.localeCompare(a, undefined, { numeric: true }) ?? 1
 }
 
 export const getWebhookEventIcon = (eventName: WebhookEventNameType) => {