Skip to content

Commit 755c127

Browse files
committed
refactor: Remove unused lastFailedStatusType from DeploymentStatusDetailsBreakdownDataType and update related types
1 parent f97f6ca commit 755c127

File tree

3 files changed

+4
-18
lines changed

3 files changed

+4
-18
lines changed

src/Shared/Components/CICDHistory/types.tsx

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -527,14 +527,6 @@ export interface DeploymentStatusDetailRowType extends Pick<DeploymentStatusDeta
527527
deploymentDetailedData: DeploymentStatusDetailsBreakdownDataType
528528
}
529529

530-
export interface ErrorInfoStatusBarType {
531-
lastFailedStatusType: string
532-
type: string
533-
errorMessage: string
534-
hideVerticalConnector?: boolean
535-
hideErrorIcon?: boolean
536-
}
537-
538530
export interface DeploymentConfigurationsRes extends ResponseType {
539531
result?: DeploymentTemplateList[]
540532
}

src/Shared/Components/DeploymentStatusBreakdown/utils.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ const getDefaultDeploymentStatusTimeline = (
4040
deploymentTriggerTime: data?.deploymentStartedOn || '',
4141
deploymentEndTime: data?.deploymentFinishedOn || '',
4242
triggeredBy: data?.triggeredBy || '',
43-
lastFailedStatusType: '',
4443
deploymentStatusBreakdown: {
4544
[TIMELINE_STATUS.DEPLOYMENT_INITIATED]: {
4645
...commonProps,

src/Shared/types.ts

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ import {
3535
VariableType,
3636
VulnerabilityType,
3737
} from '../Common'
38-
import { SelectPickerOptionType } from './Components'
38+
import { SelectPickerOptionType, WorkflowRunnerStatusDTO } from './Components'
3939
import { BASE_CONFIGURATION_ENV_ID, DEPLOYMENT_STATUS, EnvironmentTypeEnum, PatchOperationType } from './constants'
4040

4141
export enum EnvType {
@@ -1175,9 +1175,8 @@ export interface SyncStageResourceDetail {
11751175
statusMessage: string
11761176
}
11771177

1178-
export interface DeploymentStatusDetailsTimelineType {
1179-
id: number
1180-
cdWorkflowRunnerId: number
1178+
export interface DeploymentStatusDetailsTimelineType
1179+
extends Pick<SyncStageResourceDetail, 'id' | 'cdWorkflowRunnerId'> {
11811180
status: string
11821181
statusDetail: string
11831182
statusTime: string
@@ -1191,7 +1190,7 @@ export interface DeploymentStatusDetailsType {
11911190
statusFetchCount: number
11921191
statusLastFetchedAt: string
11931192
timelines: DeploymentStatusDetailsTimelineType[]
1194-
wfrStatus?: string
1193+
wfrStatus?: WorkflowRunnerStatusDTO
11951194
isDeploymentWithoutApproval: boolean
11961195
}
11971196

@@ -1274,10 +1273,6 @@ export interface DeploymentStatusDetailsBreakdownDataType {
12741273
deploymentTriggerTime: string
12751274
deploymentEndTime: string
12761275
triggeredBy: string
1277-
/**
1278-
* Only required - isHelmManifestPushFailed === true then in error bar below heading tile
1279-
*/
1280-
lastFailedStatusType?: DeploymentStatusTimelineType | ''
12811276
deploymentStatusBreakdown: Partial<Record<DeploymentStatusTimelineType, DeploymentStatusBreakdownItemType>>
12821277
}
12831278

0 commit comments

Comments
 (0)