Skip to content

Commit 7471618

Browse files
committed
Merge branch 'develop' of https://github.com/devtron-labs/devtron-fe-common-lib into feat/calc-cleanup
2 parents 58ce16d + 84bf352 commit 7471618

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+893
-354
lines changed

.eslintignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ src/Common/Drawer/Drawer.tsx
3030
src/Common/Grid/Grid.tsx
3131
src/Common/Helper.tsx
3232
src/Common/Hooks/UseClickOutside/UseClickOutside.tsx
33-
src/Common/Hooks/UseSuperAdmin/UseSuperAdmin.tsx
3433
src/Common/Hooks/UseWindowSize/UseWindowSize.tsx
3534
src/Common/ImageTags.tsx
3635
src/Common/InfoColorBar/InfoColourbar.tsx

package-lock.json

Lines changed: 18 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@devtron-labs/devtron-fe-common-lib",
3-
"version": "1.8.4",
3+
"version": "1.8.8",
44
"description": "Supporting common component library",
55
"type": "module",
66
"main": "dist/index.js",
@@ -107,7 +107,8 @@
107107
"@replit/codemirror-indentation-markers": "6.5.3",
108108
"@replit/codemirror-vscode-keymap": "6.0.2",
109109
"@types/react-dates": "^21.8.6",
110-
"@uiw/codemirror-theme-github": "^4.23.7",
110+
"@uiw/codemirror-extensions-hyper-link": "4.23.10",
111+
"@uiw/codemirror-theme-github": "4.23.7",
111112
"@uiw/react-codemirror": "4.23.7",
112113
"ansi_up": "^5.2.1",
113114
"codemirror-json-schema": "0.8.0",

src/Assets/IconV2/ic-crown.svg

Lines changed: 3 additions & 0 deletions
Loading

src/Assets/IconV2/ic-user-key.svg

Lines changed: 4 additions & 0 deletions
Loading

src/Common/AddCDButton/AddCDButton.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ const TooltipContent = ({ tooltipContent }: TooltipContentProps) => {
2222
if (tooltipContent) {
2323
return (
2424
<div className="dc__white-space-pre-wrap">
25-
<p className="m-0 cn-0 fs-12 fw-6 lh-18">Click to add</p>
25+
<p className="m-0 fs-12 fw-6 lh-18">Click to add</p>
2626

2727
{tooltipContent}
2828
</div>

src/Common/ChartVersionAndTypeSelector.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ const ChartVersionAndTypeSelector = ({ setSelectedChartRefId }: ChartVersionAndT
7575
}
7676

7777
return (
78-
<div className="flex">
78+
<div className="flex left">
7979
<div className="chart-type-options flex" data-testid="chart-type-options">
8080
<span className="cn-7 mr-4">Chart Type</span>
8181
<SelectPicker

src/Common/CodeEditor/CodeEditor.tsx

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -391,16 +391,19 @@ const Header: React.FC<CodeEditorHeaderInterface> & CodeEditorHeaderComposition
391391
children,
392392
className,
393393
hideDefaultSplitHeader,
394-
diffViewWidth,
395394
}) => {
396-
const { defaultValue } = useCodeEditorContext()
395+
const { defaultValue, state } = useCodeEditorContext()
397396
return (
398-
<div
399-
className={className || 'code-editor__header flex right'}
400-
style={{ ...(diffViewWidth ? { width: 'calc(100% - 30px)' } : {}) }}
401-
>
402-
{children}
403-
{!hideDefaultSplitHeader && defaultValue && <SplitPane />}
397+
<div className="flexbox w-100 dc__border-bottom ">
398+
<div
399+
data-code-editor-header
400+
className={`code-editor__header flex-grow-1 bg__secondary ${className || 'px-16 pt-6 pb-5'} ${state.diffMode ? 'dc__grid-half vertical-divider' : ''}`}
401+
402+
>
403+
{children}
404+
{!hideDefaultSplitHeader && defaultValue && <SplitPane />}
405+
</div>
406+
{state.diffMode ? <div className="bg__secondary px-15 dc__align-self-stretch" /> : null}
404407
</div>
405408
)
406409
}

src/Common/CodeEditor/codeEditor.scss

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@
1515
*/
1616

1717
.code-editor__header {
18-
height: 40px;
19-
background: var(--N100);
20-
padding: 0 16px;
21-
border-bottom: 1px solid var(--N200);
22-
2318
.radio-group {
2419
height: 24px;
2520
overflow: hidden;

src/Common/CodeEditor/types.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ export interface CodeEditorHeaderInterface {
8282
children?: any
8383
className?: string
8484
hideDefaultSplitHeader?: boolean
85-
diffViewWidth?: boolean
8685
}
8786
export interface CodeEditorComposition {
8887
Header?: React.FC<any>
@@ -102,7 +101,7 @@ export interface CodeEditorHeaderComposition {
102101
Clipboard?: React.FC<any>
103102
}
104103

105-
export type ActionTypes = 'changeLanguage' | 'setDiff' | 'setTheme' | 'setCode' | 'setDefaultCode' | 'setHeight'
104+
type ActionTypes = 'changeLanguage' | 'setDiff' | 'setTheme' | 'setCode' | 'setDefaultCode' | 'setHeight'
106105

107106
export interface Action {
108107
type: ActionTypes

0 commit comments

Comments
 (0)