Skip to content

Commit 719352e

Browse files
committed
fix: review comments
1 parent 9a77f98 commit 719352e

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/Shared/Components/FeatureDescription/FeatureDescriptionModal.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,11 @@ export const FeatureDescriptionModal = ({
5757

5858
const renderFooter = () => (
5959
<div
60-
className={`flex right w-100 dc__align-right pt-16 dc__border-top-n1 pb-16 pl-20 pr-20 pt-6 pb-6 ${docLink ? 'dc__content-space' : 'right'}`}
60+
className={`flex right w-100 dc__align-right dc__border-top-n1 px-20 py-16 ${docLink ? 'dc__content-space' : 'right'}`}
6161
>
6262
{docLink.length > 0 && (
6363
<a
64-
className="flex dc__link en-2 bw-1 pl-8 pr-8 dc__gap-6 br-4 fw-6 lh-20 pt-6 pb-6 h-32"
64+
className="flex dc__link en-2 bw-1 dc__gap-6 br-4 fw-6 lh-20 px-8 py-6 h-32"
6565
href={docLink}
6666
target="_blank"
6767
rel="noreferrer"

src/Shared/Components/ImageWithFallback/ImageWithFallback.component.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const ImageWithFallback = ({ imageProps, fallbackImage }: ImageWithFallbackProps
2424
// eslint-disable-next-line react/jsx-no-useless-fragment
2525
<>
2626
{imageUrl || (!imageUrl && typeof fallbackImage === 'string') ? (
27-
<img alt="" {...imageProps} src={imageUrl} onError={handleImageError} />
27+
<img alt="" {...imageProps} src={imageUrl || (fallbackImage as string)} onError={handleImageError} />
2828
) : (
2929
fallbackImage
3030
)}

src/Shared/validations.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,8 @@ export const validateURL = (url: string, allowBase64Url: boolean = true): Valida
183183
if (!allowBase64Url && isBase64Url(url)) {
184184
throw new Error('Base64 URLs are not allowed')
185185
}
186-
// eslint-disable-next-line @typescript-eslint/no-unused-vars
187-
const urlObject = new URL(url)
186+
// eslint-disable-next-line no-new
187+
new URL(url)
188188
} catch (err) {
189189
return {
190190
isValid: false,

0 commit comments

Comments
 (0)