fix: filter dependency in case of persistent filters

AbhishekA1509 · AbhishekA1509 · commit 6f105ed0309e · 2024-07-10T10:56:03.000+05:30
diff --git a/src/Shared/Components/Plugin/PluginListContainer.tsx b/src/Shared/Components/Plugin/PluginListContainer.tsx
@@ -79,7 +79,8 @@ const PluginListContainer = ({
 
     const [isLoadingPluginData, pluginData, pluginDataError, reloadPluginData] = useAsync(
         getPluginStoreDataWrapper,
-        persistFilters ? [pluginList] : [searchKey, appId, selectedTags],
+        // In case of persistFilters with change of searchKey or selectedTags we anyways clear the pluginList so no need to add dependency
+        [searchKey, appId, selectedTags],
         persistFilters ? !pluginList.length : true,
     )
 

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,8 @@ const PluginListContainer = ({`
`79`	`79`
`80`	`80`	`const [isLoadingPluginData, pluginData, pluginDataError, reloadPluginData] = useAsync(`
`81`	`81`	`getPluginStoreDataWrapper,`
`82`		`- persistFilters ? [pluginList] : [searchKey, appId, selectedTags],`
	`82`	`+ // In case of persistFilters with change of searchKey or selectedTags we anyways clear the pluginList so no need to add dependency`
	`83`	`+ [searchKey, appId, selectedTags],`
`83`	`84`	`persistFilters ? !pluginList.length : true,`
`84`	`85`	`)`
`85`	`86`