Skip to content

Commit 67be9e4

Browse files
authored
Merge pull request #658 from devtron-labs/refactor/plugin-policy-v1
refactor: remove plugin policy v1 code and theming feature flag
2 parents 16f8380 + a84e325 commit 67be9e4

File tree

5 files changed

+3
-27
lines changed

5 files changed

+3
-27
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@devtron-labs/devtron-fe-common-lib",
3-
"version": "1.10.3",
3+
"version": "1.10.4",
44
"description": "Supporting common component library",
55
"type": "module",
66
"main": "dist/index.js",

src/Shared/Components/ThemeSwitcher/ThemeSwitcher.component.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ import { LOGOUT_CARD_BASE_BUTTON_CLASS } from '../LogoutCard'
2222
const ThemeSwitcher = ({ onChange }: ThemeSwitcherProps) => {
2323
const { handleThemeSwitcherDialogVisibilityChange, themePreference } = useTheme()
2424

25-
if (!window._env_.FEATURE_EXPERIMENTAL_THEMING_ENABLE) {
26-
return null
27-
}
28-
2925
const handleShowThemeSwitcherDialog = () => {
3026
handleThemeSwitcherDialogVisibilityChange(true)
3127
onChange()

src/Shared/Providers/ThemeProvider/utils.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,6 @@ export const logThemeToAnalytics = ({ appTheme, themePreference }: ThemeConfigTy
4545
}
4646

4747
export const getThemeConfigFromLocalStorage = (): ThemeConfigType => {
48-
// Handling the case if the theming is turned off at a later stage
49-
if (!window._env_.FEATURE_EXPERIMENTAL_THEMING_ENABLE) {
50-
return {
51-
appTheme: AppThemeType.light,
52-
themePreference: THEME_PREFERENCE_MAP.light,
53-
}
54-
}
55-
5648
const selectedTheme = localStorage.getItem(THEME_PREFERENCE_STORAGE_KEY) as ThemePreferenceType
5749

5850
if (!selectedTheme || selectedTheme === THEME_PREFERENCE_MAP.auto) {

src/index.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -90,12 +90,6 @@ export interface customEnv {
9090
FEATURE_DEFAULT_MERGE_STRATEGY?: OverrideMergeStrategyType
9191
FEATURE_DEFAULT_LANDING_RB_ENABLE?: boolean
9292
FEATURE_ACTION_AUDIOS_ENABLE?: boolean
93-
/**
94-
* If true, the experimental theming feature is enabled
95-
*
96-
* @default false
97-
*/
98-
FEATURE_EXPERIMENTAL_THEMING_ENABLE?: boolean
9993
/**
10094
* If true, the code-editor will use codemirror engine
10195
* @default false
@@ -143,12 +137,6 @@ export interface customEnv {
143137
* @default false
144138
*/
145139
FEATURE_SWAP_TRAFFIC_ENABLE?: boolean
146-
/**
147-
* Enable mandatory plugins for cd
148-
*
149-
* @default true
150-
*/
151-
FEATURE_CD_MANDATORY_PLUGINS_ENABLE?: boolean
152140
/**
153141
* Enable cluster map
154142
*

0 commit comments

Comments
 (0)