Merge pull request #271 from devtron-labs/fix/select-types

eshankvaish · web-flow · commit 63a87cc10192 · 2024-08-29T11:38:38.000+05:30
fix: type issue for select picker module augmentation
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@devtron-labs/devtron-fe-common-lib",
-    "version": "0.2.18",
+    "version": "0.2.19",
     "description": "Supporting common component library",
     "type": "module",
     "main": "dist/index.js",
diff --git a/src/Shared/Components/SelectPicker/type.ts b/src/Shared/Components/SelectPicker/type.ts
@@ -98,10 +98,13 @@ export type SelectPickerProps<OptionValue = number | string, IsMulti extends boo
     | 'onMenuClose'
     | 'autoFocus'
     | 'onBlur'
-    | 'renderMenuListFooter'
-    | 'shouldRenderCustomOptions'
-    | 'renderCustomOptions'
 > &
+    Partial<
+        Pick<
+            SelectProps<OptionValue, IsMulti>,
+            'renderMenuListFooter' | 'shouldRenderCustomOptions' | 'renderCustomOptions'
+        >
+    > &
     Required<Pick<SelectProps<OptionValue, IsMulti>, 'inputId'>> & {
         /**
          * Icon to be rendered in the control

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@devtron-labs/devtron-fe-common-lib",`
`3`		`- "version": "0.2.18",`
	`3`	`+ "version": "0.2.19",`
`4`	`4`	`"description": "Supporting common component library",`
`5`	`5`	`"type": "module",`
`6`	`6`	`"main": "dist/index.js",`