Skip to content

Commit 5b441aa

Browse files
committed
fix: update typing for user group dto as per updated specs
1 parent 9695d47 commit 5b441aa

File tree

3 files changed

+13
-6
lines changed

3 files changed

+13
-6
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@devtron-labs/devtron-fe-common-lib",
3-
"version": "0.2.6-beta-1",
3+
"version": "0.2.6-beta-2",
44
"description": "Supporting common component library",
55
"type": "module",
66
"main": "dist/index.js",

src/Pages/GlobalConfigurations/Authorization/types.ts

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,18 @@ export interface UserGroupDTO {
5959
*
6060
* Follows the validation for app name
6161
*/
62-
userGroupId: string
62+
identifier: string
6363
/**
6464
* Associated description
6565
*/
66-
description: string
66+
description?: string
6767
}
6868

69-
export interface UserGroupType extends UserGroupDTO {}
69+
export interface UserGroupType extends Required<Pick<UserGroupDTO, 'description' | 'name'>> {
70+
/**
71+
* Unique id of the user group
72+
*
73+
* Follows the validation for app name
74+
*/
75+
userGroupId: string
76+
}

0 commit comments

Comments
 (0)