Skip to content

Commit 56af679

Browse files
authored
Merge pull request #582 from devtron-labs/feat/text-field
feat: update the API for CustomInput
2 parents 08678f8 + 3278f6f commit 56af679

33 files changed

+653
-450
lines changed

.eslintignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ src/Common/Checkbox.tsx
1313
src/Common/ClipboardButton/__tests__/ClipboardButton.test.tsx
1414
src/Common/CodeEditor/CodeEditor.tsx
1515
src/Common/Common.service.ts
16-
src/Common/CustomInput/CustomInput.tsx
1716
src/Common/CustomTagSelector/PropagateTagInfo.tsx
1817
src/Common/CustomTagSelector/TagDetails.tsx
1918
src/Common/CustomTagSelector/TagLabelValueSelector.tsx

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@devtron-labs/devtron-fe-common-lib",
3-
"version": "1.7.2",
3+
"version": "1.7.3",
44
"description": "Supporting common component library",
55
"type": "module",
66
"main": "dist/index.js",

src/Assets/Icon/ic-visibility-off.svg

Lines changed: 19 additions & 0 deletions
Loading

src/Assets/Icon/ic-visibility-on.svg

Lines changed: 20 additions & 0 deletions
Loading

src/Common/CustomInput/CustomInput.tsx

Lines changed: 0 additions & 160 deletions
This file was deleted.

src/Common/CustomInput/Types.ts

Lines changed: 0 additions & 47 deletions
This file was deleted.

src/Common/Tooltip/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,4 @@
1616

1717
export { default as Tooltip } from './Tooltip'
1818
export { TOOLTIP_CONTENTS } from './constants'
19+
export type { TooltipProps } from './types'

src/Common/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ export * from './RJSF'
5959
export * from './DevtronProgressing'
6060
export { default as ChartVersionAndTypeSelector } from './ChartVersionAndTypeSelector'
6161
export * from './AddCDButton'
62-
export * from './CustomInput'
6362
export * from './DraggableWrapper'
6463
export * from './Pagination'
6564
export * from './Markdown'

src/Pages/GlobalConfigurations/BuildInfra/BuildInfraProfileNameField.tsx

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
*/
1616

1717
import { FormEvent, FunctionComponent } from 'react'
18+
import { CustomInput } from '@Shared/Components'
1819
import { BuildInfraMetaConfigTypes, BuildInfraProfileMetaFieldProps } from './types'
19-
import { CustomInput } from '../../../Common'
2020
import { BUILD_INFRA_TEXT } from './constants'
2121

2222
const BuildInfraProfileNameField: FunctionComponent<BuildInfraProfileMetaFieldProps> = ({
@@ -38,20 +38,17 @@ const BuildInfraProfileNameField: FunctionComponent<BuildInfraProfileMetaFieldPr
3838
}
3939

4040
return (
41-
<div className="flexbox-col dc__gap-4 w-100 dc__align-start">
42-
<CustomInput
43-
name="profile-name"
44-
label={BUILD_INFRA_TEXT.PROFILE_LABEL}
45-
labelClassName="m-0 dc__required-field fs-13 fw-4 lh-20 cn-7"
46-
placeholder={BUILD_INFRA_TEXT.PROFILE_PLACEHOLDER}
47-
value={currentValue}
48-
onChange={handleChange}
49-
error={error}
50-
required
51-
inputWrapClassName="w-100"
52-
autoFocus
53-
/>
54-
</div>
41+
<CustomInput
42+
name="profile-name"
43+
label={BUILD_INFRA_TEXT.PROFILE_LABEL}
44+
placeholder={BUILD_INFRA_TEXT.PROFILE_PLACEHOLDER}
45+
value={currentValue}
46+
onChange={handleChange}
47+
error={error}
48+
required
49+
fullWidth
50+
autoFocus
51+
/>
5552
)
5653
}
5754

0 commit comments

Comments
 (0)