feat: enhance handleThemePreferenceChange to support local updates and prevent unnecessary storage/analytics updates

Author: AbhishekA1509

src/Shared/Providers/ThemeProvider/ThemeProvider.tsx

@@ -31,7 +31,10 @@ export const ThemeProvider = ({ children }: ThemeProviderProps) => {
     const [showSwitchThemeLocationTippy, setShowSwitchThemeLocationTippy] = useState<boolean>(false)
     const [themeConfig, setThemeConfig] = useState<ThemeConfigType>(getThemeConfigFromLocalStorage)
 
-    const handleThemePreferenceChange: ThemeContextType['handleThemePreferenceChange'] = (updatedThemePreference) => {
+    const handleThemePreferenceChange: ThemeContextType['handleThemePreferenceChange'] = (
+        updatedThemePreference,
+        isLocalUpdate = false,
+    ) => {
         const updatedThemeConfig: ThemeConfigType = {
             appTheme:
                 updatedThemePreference === THEME_PREFERENCE_MAP.auto
@@ -40,8 +43,10 @@ export const ThemeProvider = ({ children }: ThemeProviderProps) => {
             themePreference: updatedThemePreference,
         }
         setThemeConfig(updatedThemeConfig)
-        setThemePreferenceInLocalStorage(updatedThemePreference)
-        logThemeToAnalytics(updatedThemeConfig)
+        if (!isLocalUpdate) {
+            setThemePreferenceInLocalStorage(updatedThemePreference)
+            logThemeToAnalytics(updatedThemeConfig)
+        }
     }
 
     const handleColorSchemeChange = () => {

src/Shared/Providers/ThemeProvider/index.ts

@@ -17,3 +17,4 @@
 export * from './ThemeProvider'
 export { AppThemeType } from './types'
 export { getComponentSpecificThemeClass, getThemePreferenceText } from './utils'
+export { THEME_PREFERENCE_STORAGE_KEY } from './constants'

src/Shared/Providers/ThemeProvider/types.ts

@@ -50,7 +50,13 @@ export interface ThemeContextType extends ThemeConfigType {
     handleShowSwitchThemeLocationTippyChange: (isVisible: boolean) => void
     showThemeSwitcherDialog: boolean
     handleThemeSwitcherDialogVisibilityChange: (isVisible: boolean) => void
-    handleThemePreferenceChange: (updatedThemePreference: ThemePreferenceType) => void
+    handleThemePreferenceChange: (
+        updatedThemePreference: ThemePreferenceType,
+        /**
+         * @description If update is local we won't update local storage and analytics
+         * */
+        isLocalUpdate?: boolean,
+    ) => void
 }
 
 export interface ThemeProviderProps {