Skip to content

Commit 3e30962

Browse files
committed
Merge branch 'develop' into feat/change-to-overflow-auto
2 parents c825723 + cf3ca57 commit 3e30962

31 files changed

+351
-214
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@devtron-labs/devtron-fe-common-lib",
3-
"version": "1.4.9-beta-1",
3+
"version": "1.5.2-beta-1",
44
"description": "Supporting common component library",
55
"type": "module",
66
"main": "dist/index.js",

src/Assets/Img/delete-medium.svg

Lines changed: 1 addition & 1 deletion
Loading

src/Assets/Img/ic-not-authorized.svg

Lines changed: 1 addition & 1 deletion
Loading

src/Assets/Img/ic-not-found.svg

Lines changed: 1 addition & 1 deletion
Loading

src/Assets/Img/ic-page-not-found.svg

Lines changed: 1 addition & 1 deletion
Loading

src/Common/CodeEditor/CodeEditor.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import { configureMonacoYaml } from 'monaco-yaml'
2323
import { ReactComponent as ICWarningY5 } from '@Icons/ic-warning-y5.svg'
2424
import { ReactComponent as Info } from '../../Assets/Icon/ic-info-filled.svg'
2525
import { ReactComponent as ErrorIcon } from '../../Assets/Icon/ic-error-exclamation.svg'
26+
import { ReactComponent as ICCompare } from '@Icons/ic-compare.svg'
2627
import './codeEditor.scss'
2728
import 'monaco-editor'
2829

@@ -491,7 +492,7 @@ const SplitPane = ({}) => {
491492
}
492493
return (
493494
<div className="code-editor__split-pane flex pointer" onClick={handleToggle}>
494-
<div className="diff-icon" />
495+
<ICCompare className="icon-dim-20 mr-4" />
495496
{state.diffMode ? 'Hide comparison' : 'Compare with default'}
496497
</div>
497498
)

src/Common/CodeEditor/codeEditor.scss

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -121,13 +121,6 @@
121121
color: var(--N0);
122122
}
123123

124-
.diff-icon {
125-
height: 20px;
126-
width: 20px;
127-
margin-right: 4px;
128-
background: url('../../Assets/Icon/ic-compare.svg');
129-
}
130-
131124
.monaco-editor-hover {
132125
margin-left: 40px;
133126
}

src/Common/GenericDescription/genericDescription.scss

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,11 +116,17 @@
116116
.mde-preview-content {
117117
padding: 0px !important;
118118

119-
a.anchor {
120-
color: var(--N900);
119+
a {
120+
color: var(--B500);
121121

122-
h1, h2, h3 {
123-
border-bottom: 1px solid var(--N200);
122+
&.anchor {
123+
color: var(--N900);
124+
125+
h1,
126+
h2,
127+
h3 {
128+
border-bottom: 1px solid var(--N200);
129+
}
124130
}
125131
}
126132

src/Common/Helper.tsx

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,11 @@ import {
4545
WebhookEventNameType,
4646
} from '../Shared'
4747
import { ReactComponent as ArrowDown } from '@Icons/ic-chevron-down.svg'
48-
import webhookIcon from '@Icons/ic-webhook.svg'
49-
import branchIcon from '@Icons/ic-branch.svg'
50-
import regexIcon from '@Icons/ic-regex.svg'
51-
import pullRequest from '@Icons/ic-pull-request.svg'
52-
import tagIcon from '@Icons/ic-tag.svg'
48+
import { ReactComponent as ICWebhook } from '@Icons/ic-webhook.svg'
49+
import { ReactComponent as ICBranch } from '@Icons/ic-branch.svg'
50+
import { ReactComponent as ICRegex } from '@Icons/ic-regex.svg'
51+
import { ReactComponent as ICPullRequest } from '@Icons/ic-pull-request.svg'
52+
import { ReactComponent as ICTag } from '@Icons/ic-tag.svg'
5353
import { SourceTypeMap } from '@Common/Common.service'
5454
import { getIsRequestAborted } from './Api'
5555

@@ -990,17 +990,17 @@ export const throttle = <T extends (...args: unknown[]) => unknown>(
990990
export const getBranchIcon = (sourceType, _isRegex?: boolean, webhookEventName?: string) => {
991991
if (sourceType === SourceTypeMap.WEBHOOK) {
992992
if (webhookEventName === WebhookEventNameType.PULL_REQUEST) {
993-
return pullRequest
993+
return <ICPullRequest className="scn-6" />
994994
}
995995
if (webhookEventName === WebhookEventNameType.TAG_CREATION) {
996-
return tagIcon
996+
return <ICTag className="scn-6" />
997997
}
998-
return webhookIcon
998+
return <ICWebhook />
999999
}
10001000
if (sourceType === SourceTypeMap.BranchRegex || _isRegex) {
1001-
return regexIcon
1001+
return <ICRegex className="fcn-6" />
10021002
}
1003-
return branchIcon
1003+
return <ICBranch className="fcn-6" />
10041004
}
10051005

10061006
// TODO: Might need to expose sandbox and referrer policy

0 commit comments

Comments
 (0)