Skip to content

Commit 37cb587

Browse files
committed
fix: appName check added in case of invalid appId
1 parent 672e2b3 commit 37cb587

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@devtron-labs/devtron-fe-common-lib",
3-
"version": "1.10.15-beta-1",
3+
"version": "1.10.15-beta-2",
44
"description": "Supporting common component library",
55
"type": "module",
66
"main": "dist/index.js",

src/Shared/Hooks/useUserPreferences/utils.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,12 @@ export const getFilteredUniqueAppList = ({
2121
UserPreferenceResourceActions.RECENTLY_VISITED
2222
] || []
2323

24-
// Ensure all items have valid `appId` and `appName`
2524
const validApps = _recentApps.filter((app) => app?.appId && app?.appName)
2625

2726
// Convert to a Map for uniqueness while maintaining stacking order
28-
const uniqueApps = [
29-
{ appId, appName }, // Ensure new app is on top
30-
...validApps.filter((app) => app.appId !== appId), // Keep previous order, remove duplicate
31-
].slice(0, 6) // Limit to 6 items
27+
const uniqueApps = (
28+
appId && appName ? [{ appId, appName }, ...validApps.filter((app) => app.appId !== appId)] : validApps
29+
).slice(0, 6) // Limit to 6 items
3230

3331
return isInvalidAppId ? uniqueApps.filter((app) => app.appId !== Number(appId)) : uniqueApps
3432
}

0 commit comments

Comments
 (0)