refactor: improve null checks and declaration

Author: eshankvaish

src/Common/Dialogs/DeleteDialog.tsx

@@ -30,7 +30,7 @@ export const DeleteDialog: React.FC<DeleteDialogProps> & { Description?: React.F
         props.delete()
     }
 
-    const handleKeyDown = async (event: KeyboardEvent) => {
+    const handleKeyDown = (event: KeyboardEvent) => {
         if (event.key === 'Enter' && !isDeleteDisabled) {
             event.preventDefault()
 

src/Common/Hooks/useUrlFilters/useUrlFilters.ts

@@ -73,9 +73,10 @@ const useUrlFilters = <T = string, K = unknown>({
     const _resetPageNumber = () => {
         if (pageNumber !== DEFAULT_PAGE_NUMBER) {
             _updateSearchParam(PAGE_NUMBER, DEFAULT_PAGE_NUMBER)
-        } else {
-            history.replace({ search: searchParams.toString() })
+            return
         }
+
+        history.replace({ search: searchParams.toString() })
     }
 
     const changePage = (page: number) => {

src/Common/Modals/VisibleModal.tsx

@@ -49,17 +49,17 @@ export class VisibleModal extends React.Component<{
         }
     }
 
-    render() {
-        const handleBodyClick = (e: SyntheticEvent) => {
-            e.stopPropagation()
+    handleBodyClick = (e: SyntheticEvent) => {
+        e.stopPropagation()
 
-            this.props?.close?.(e)
-        }
+        this.props.close?.(e)
+    }
 
+    render() {
         return ReactDOM.createPortal(
             <div
                 className={`visible-modal__body ${this.props.className}`}
-                onClick={handleBodyClick}
+                onClick={this.handleBodyClick}
                 data-testid="visible-modal-close"
             >
                 {this.props.children}

src/Common/Modals/VisibleModal2.tsx

@@ -30,17 +30,17 @@ export class VisibleModal2 extends React.Component<{ className: string; close?:
         preventBodyScroll(false)
     }
 
-    render() {
-        const handleBodyClick = (e: SyntheticEvent) => {
-            e.stopPropagation()
+    handleBodyClick = (e: SyntheticEvent) => {
+        e.stopPropagation()
 
-            this.props?.close?.(e)
-        }
+        this.props.close?.(e)
+    }
 
+    render() {
         return ReactDOM.createPortal(
             <div
                 className={`visible-modal__body ${this.props.className}`}
-                onClick={handleBodyClick}
+                onClick={this.handleBodyClick}
                 data-testid="visible-modal2-close"
             >
                 {this.props.children}