Skip to content

Commit 3205923

Browse files
committed
chore: Update package version to 0.2.6-beta-7
1 parent d10b31d commit 3205923

File tree

3 files changed

+24
-6
lines changed

3 files changed

+24
-6
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@devtron-labs/devtron-fe-common-lib",
3-
"version": "0.2.6-beta-6",
3+
"version": "0.2.6-beta-7",
44
"description": "Supporting common component library",
55
"type": "module",
66
"main": "dist/index.js",

src/Common/Common.service.ts

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import {
3636
ImageApprovalPolicyUserGroupDataType,
3737
ImageApprovalPolicyType,
3838
ImageApprovalUsersInfoDTO,
39+
UserApprovalMetadataType,
3940
} from './Types'
4041
import { ApiResourceType } from '../Pages'
4142
import { getIsManualApprovalSpecific, sanitizeUserApprovalConfig, stringComparatorBySortOrder } from '@Shared/Helpers'
@@ -87,6 +88,23 @@ export function setImageTags(request, pipelineId: number, artifactId: number) {
8788
return post(`${ROUTES.IMAGE_TAGGING}/${pipelineId}/${artifactId}`, request)
8889
}
8990

91+
const sanitizeApprovalConfigFromApprovalMetadata = (approvalMetadata: UserApprovalMetadataType):UserApprovalMetadataType => {
92+
if (!approvalMetadata) {
93+
return null
94+
}
95+
96+
const approvedUsersData = approvalMetadata.approvedUsersData || []
97+
98+
return {
99+
...approvalMetadata,
100+
approvedUsersData: approvedUsersData.map((userData) => ({
101+
...userData,
102+
userGroups: userData.userGroups?.filter((group) => !!group?.identifier && !!group?.name) ?? [],
103+
})),
104+
approvalConfig: sanitizeUserApprovalConfig(approvalMetadata.approvalConfig),
105+
}
106+
}
107+
90108
const cdMaterialListModal = (
91109
artifacts: any[],
92110
offset: number,
@@ -137,7 +155,7 @@ const cdMaterialListModal = (
137155
vulnerable: material.vulnerable,
138156
runningOnParentCd: material.runningOnParentCd,
139157
artifactStatus: artifactStatusValue,
140-
userApprovalMetadata: material.userApprovalMetadata,
158+
userApprovalMetadata: sanitizeApprovalConfigFromApprovalMetadata(material.userApprovalMetadata),
141159
triggeredBy: material.triggeredBy,
142160
isVirtualEnvironment: material.isVirtualEnvironment,
143161
imageComment: material.imageComment,
@@ -221,7 +239,7 @@ const getImageApprovalPolicyDetailsFromMaterialResult = (cdMaterialsResult): Ima
221239
const validGroups = userApprovalConfig.userGroups.map((group) => group.identifier)
222240

223241
const usersList = Object.keys(imageApprovalUsersInfo).filter((user) => user !== DefaultUserKey.system)
224-
const userToGroupMap = usersList.reduce(
242+
const groupIdentifierToUsersMap = usersList.reduce(
225243
(acc, user) => {
226244
const userGroups = imageApprovalUsersInfo[user] || []
227245
userGroups.forEach((group) => {
@@ -242,7 +260,7 @@ const getImageApprovalPolicyDetailsFromMaterialResult = (cdMaterialsResult): Ima
242260
(acc, group) => {
243261
const identifier = group.identifier
244262
// No need of handling api tokens here since they are not part of user groups
245-
const users = Object.keys(userToGroupMap[identifier] || {}).sort(stringComparatorBySortOrder)
263+
const users = Object.keys(groupIdentifierToUsersMap[identifier] || {}).sort(stringComparatorBySortOrder)
246264

247265
acc[identifier] = {
248266
dataStore: users.reduce(

0 commit comments

Comments
 (0)