Merge pull request #246 from devtron-labs/feat/dynamic-code-editor-height

feat: add support for content based editor height

Author: Elessar1802

package-lock.json

@@ -1,6 +1,6 @@
 {
     "name": "@devtron-labs/devtron-fe-common-lib",
-    "version": "0.2.13",
+    "version": "0.2.14",
     "description": "Supporting common component library",
     "type": "module",
     "main": "dist/index.js",

package.json

@@ -87,7 +87,7 @@ const CodeEditor: React.FC<CodeEditorInterface> & CodeEditorComposition = React.
         cleanData = false,
         onBlur,
         onFocus,
-        adjustEditorHeightToContent,
+        adjustEditorHeightToContent = false,
     }) => {
         if (cleanData) {
             value = cleanKubeManifest(value)

src/Common/CodeEditor/CodeEditor.tsx

@@ -22,7 +22,7 @@ export interface InformationBarProps {
     children?: React.ReactNode
 }
 
-export interface CodeEditorInterface {
+interface CodeEditorBaseInterface {
     value?: string
     lineDecorationsWidth?: number
     responseType?: string
@@ -36,7 +36,6 @@ export interface CodeEditorInterface {
     readOnly?: boolean
     noParsing?: boolean
     inline?: boolean
-    height?: number | string
     shebang?: string | JSX.Element
     diffView?: boolean
     loading?: boolean
@@ -48,9 +47,20 @@ export interface CodeEditorInterface {
     isKubernetes?: boolean
     cleanData?: boolean
     chartVersion?: any
-    adjustEditorHeightToContent?: boolean
 }
 
+export type CodeEditorInterface = CodeEditorBaseInterface &
+    (
+        | {
+              adjustEditorHeightToContent?: boolean
+              height?: never
+          }
+        | {
+              adjustEditorHeightToContent?: never
+              height?: number | string
+          }
+    )
+
 export interface CodeEditorHeaderInterface {
     children?: any
     className?: string