Skip to content

Commit 2f25213

Browse files
authored
Merge pull request #490 from devtron-labs/fix/select-auto-focus
fix: auto focus issue for select picker
2 parents f9fc10c + bc6f6e0 commit 2f25213

File tree

5 files changed

+11
-10
lines changed

5 files changed

+11
-10
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@devtron-labs/devtron-fe-common-lib",
3-
"version": "1.3.11-beta-2",
3+
"version": "1.3.12",
44
"description": "Supporting common component library",
55
"type": "module",
66
"main": "dist/index.js",

src/Shared/Components/SelectPicker/SelectPicker.component.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -284,10 +284,9 @@ const SelectPicker = <OptionValue, IsMulti extends boolean>({
284284
{...valueContainerProps}
285285
showSelectedOptionsCount={showSelectedOptionsCount}
286286
customSelectedOptionsCount={customSelectedOptionsCount}
287-
isFocussed={isFocussed}
288287
/>
289288
),
290-
[showSelectedOptionsCount, customSelectedOptionsCount, isFocussed],
289+
[showSelectedOptionsCount, customSelectedOptionsCount],
291290
)
292291

293292
const renderOption = useCallback(
@@ -469,6 +468,7 @@ const SelectPicker = <OptionValue, IsMulti extends boolean>({
469468
onBlur={handleBlur}
470469
onChange={handleChange}
471470
controlShouldRenderValue={controlShouldRenderValue}
471+
isFocussed={isFocussed}
472472
/>
473473
</div>
474474
</ConditionalWrap>

src/Shared/Components/SelectPicker/common.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,15 +119,12 @@ export const SelectPickerInput = <OptionValue,>(props: InputProps<SelectPickerOp
119119
export const SelectPickerValueContainer = <OptionValue, IsMulti extends boolean>({
120120
showSelectedOptionsCount,
121121
customSelectedOptionsCount,
122-
isFocussed,
123122
...props
124123
}: ValueContainerProps<SelectPickerOptionType<OptionValue>> &
125-
Pick<SelectPickerProps<OptionValue, IsMulti>, 'showSelectedOptionsCount' | 'customSelectedOptionsCount'> & {
126-
isFocussed: boolean
127-
}) => {
124+
Pick<SelectPickerProps<OptionValue, IsMulti>, 'showSelectedOptionsCount' | 'customSelectedOptionsCount'>) => {
128125
const {
129126
getValue,
130-
selectProps: { customDisplayText, shouldRenderTextArea },
127+
selectProps: { customDisplayText, shouldRenderTextArea, isFocussed },
131128
children,
132129
} = props
133130

src/Shared/Components/SelectPicker/type.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,10 @@ declare module 'react-select/base' {
9898
* @default false
9999
*/
100100
shouldRenderTextArea?: boolean
101+
/**
102+
* Custom prop for the value container for focussed state
103+
*/
104+
isFocussed?: boolean
101105
}
102106
}
103107

0 commit comments

Comments
 (0)