Skip to content

Commit 2989e77

Browse files
committed
fix: tab group underline layout
1 parent 0e052bc commit 2989e77

File tree

4 files changed

+7
-8
lines changed

4 files changed

+7
-8
lines changed

src/Assets/IconV2/ic-info-filled.svg

Lines changed: 1 addition & 1 deletion
Loading

src/Shared/Components/TabGroup/TabGroup.component.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const MotionLayoutUnderline = ({ layoutId }: { layoutId: string }) => (
3535
generatedTransform.replace(/translate3d\(([^,]+),\s*[^,]+,\s*([^)]+)\)/, 'translate3d($1, 0px, $2)')
3636
}
3737
layoutId={layoutId}
38-
className="underline bcb-5"
38+
className="underline bcb-5 w-100 dc__position-abs"
3939
/>
4040
)
4141

@@ -67,7 +67,6 @@ const Tab = ({
6767

6868
const { tabClassName, iconClassName, badgeClassName } = getClassNameBySizeMap({
6969
hideTopPadding,
70-
isTabActive,
7170
})[size]
7271

7372
const onClickHandler = (

src/Shared/Components/TabGroup/TabGroup.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
height: 2px !important;
3838
border-top-left-radius: 2px;
3939
border-top-right-radius: 2px;
40+
bottom: -1px;
4041
}
4142

4243
&--active {

src/Shared/Components/TabGroup/TabGroup.utils.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@ import { TabGroupProps } from './TabGroup.types'
2121

2222
export const getClassNameBySizeMap = ({
2323
hideTopPadding,
24-
isTabActive,
25-
}: Pick<TabGroupProps, 'hideTopPadding'> & { isTabActive: boolean }): Record<
24+
}: Pick<TabGroupProps, 'hideTopPadding'>): Record<
2625
TabGroupProps['size'],
2726
{
2827
tabClassName: string
@@ -31,17 +30,17 @@ export const getClassNameBySizeMap = ({
3130
}
3231
> => ({
3332
[ComponentSizeType.medium]: {
34-
tabClassName: `fs-12 ${!hideTopPadding ? 'pt-6' : ''} ${isTabActive ? 'pb-3' : 'pb-5'}`,
33+
tabClassName: `fs-12 ${!hideTopPadding ? 'pt-6' : ''} pb-5`,
3534
iconClassName: 'icon-dim-14',
3635
badgeClassName: 'fs-11 lh-18 tab-group__tab__badge--medium',
3736
},
3837
[ComponentSizeType.large]: {
39-
tabClassName: `fs-13 ${!hideTopPadding ? 'pt-8' : ''} ${isTabActive ? 'pb-5' : 'pb-7'}`,
38+
tabClassName: `fs-13 ${!hideTopPadding ? 'pt-8' : ''} pb-7`,
4039
iconClassName: 'icon-dim-16',
4140
badgeClassName: 'fs-12 lh-20',
4241
},
4342
[ComponentSizeType.xl]: {
44-
tabClassName: `min-w-200 fs-13 ${!hideTopPadding ? 'pt-10' : ''} ${isTabActive ? 'pb-7' : 'pb-9'}`,
43+
tabClassName: `min-w-200 fs-13 ${!hideTopPadding ? 'pt-10' : ''} pb-9`,
4544
iconClassName: 'icon-dim-16',
4645
badgeClassName: 'fs-12 lh-20',
4746
},

0 commit comments

Comments
 (0)