Skip to content

Commit 210b62a

Browse files
committed
chore: update EditImageFormField component styles and dimensions
1 parent bbb7916 commit 210b62a

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

src/Shared/Components/EditImageFormField/EditImageFormField.tsx

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,14 @@ import { EditImageFormFieldProps, FallbackImageProps } from './types'
88
import { DEFAULT_IMAGE_DIMENSIONS, DEFAULT_MAX_IMAGE_SIZE } from './constants'
99
import './EditImageFormField.scss'
1010

11-
// NOTE: If want to make image dimensions configurable please change its dimensions as well for icon-dim-48.
1211
const FallbackImage = ({ showEditIcon, defaultIcon }: FallbackImageProps) => (
1312
<div
14-
className={`flex dc__align-self-start dc__no-shrink br-4 edit-image-form-field__fallback-image icon-dim-48 ${showEditIcon ? 'base-image' : ''}`}
13+
className={`flex dc__align-self-start dc__no-shrink br-4 edit-image-form-field__fallback-image p-12 ${showEditIcon ? 'base-image' : ''}`}
14+
// Adding inline style to make sure it is configurable through constants
15+
style={{
16+
height: DEFAULT_IMAGE_DIMENSIONS.height,
17+
width: DEFAULT_IMAGE_DIMENSIONS.width,
18+
}}
1519
>
1620
{defaultIcon}
1721
</div>
@@ -62,6 +66,11 @@ const EditImageFormField = ({
6266
}
6367

6468
const handlePreviewImage = async () => {
69+
if (errorMessage) {
70+
showError(errorMessage)
71+
return
72+
}
73+
6574
setIsLoading(true)
6675
try {
6776
const response = await fetch(url, { mode: 'cors' })
@@ -161,7 +170,7 @@ const EditImageFormField = ({
161170
</ButtonWithLoader>
162171

163172
<button
164-
className="cta secondary h-28 flex"
173+
className="cta cancel h-28 flex"
165174
data-testid={`${dataTestIdPrefix}-cancel`}
166175
type="button"
167176
disabled={isLoading}
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
export { default as EditImageFormField } from './EditImageFormField'
2+
export * from './types'

0 commit comments

Comments
 (0)