chore: remove todos

Author: arunjaindev

src/Shared/Components/DevtronLicenseCard/DevtronLicenseCard.tsx

@@ -2,7 +2,13 @@ import { useEffect, useRef } from 'react'
 import { animate, motion, useMotionTemplate, useMotionValue, useTransform } from 'framer-motion'
 import { ClipboardButton, getTTLInHumanReadableFormat } from '@Common/index'
 import { ReactComponent as ICChatSupport } from '@IconsV2/ic-chat-circle-dots.svg'
-import { DevtronLicenseCardProps, ENTERPRISE_SUPPORT_LINK, LicenseStatus } from '@Shared/index'
+import {
+    CONTACT_SUPPORT_LINK,
+    DevtronLicenseCardProps,
+    ENTERPRISE_SUPPORT_LINK,
+    getHandleOpenURL,
+    LicenseStatus,
+} from '@Shared/index'
 import { Button, ButtonVariantType } from '../Button'
 import { Icon } from '../Icon'
 import { getLicenseColorsAccordingToStatus } from './utils'
@@ -55,10 +61,10 @@ export const DevtronLicenseCard = ({
         }
     }, [])
 
-    const diagonalMovement = useTransform<number, number>([rotateX, rotateY], ([newRotateX, newRotateY]) => {
-        const position: number = newRotateX + newRotateY
-        return position
-    })
+    const diagonalMovement = useTransform<number, number>(
+        [rotateX, rotateY],
+        ([newRotateX, newRotateY]) => newRotateX + newRotateY,
+    )
     const sheenPosition = useTransform(diagonalMovement, [-5, 5], [-100, 200])
 
     const sheenOpacity = useTransform(sheenPosition, [-100, 50, 200], [0, 0.05, 0])
@@ -89,8 +95,8 @@ export const DevtronLicenseCard = ({
                             </div>
                             {licenseKey && <ClipboardButton content={licenseKey} />}
                         </div>
-                        <div className="flexbox dc__align-items-center dc__gap-4 font-ibm-plex-mono">
-                            <span>{expiryDate}</span>
+                        <div className="flexbox dc__align-items-center dc__gap-4 flex-wrap">
+                            <span className="font-ibm-plex-mono">{expiryDate}</span>
                             <span>•</span>
                             <span style={{ color: textColor }}>{remainingTimeString}</span>
                         </div>
@@ -116,12 +122,12 @@ export const DevtronLicenseCard = ({
                             size={16}
                         />
                     </div>
-                    {/* TODO: Add onClick, and common out the button */}
                     <Button
                         dataTestId="contact-support"
                         startIcon={<ICChatSupport />}
                         text="Contact support"
                         variant={ButtonVariantType.text}
+                        onClick={getHandleOpenURL(CONTACT_SUPPORT_LINK)}
                     />
                 </div>
             )}

src/Shared/Components/Header/HelpNav.tsx

@@ -115,6 +115,7 @@ const HelpNav = ({
                                 type="button"
                                 className="dc__transparent help-card__option flexbox dc__align-items-center cn-9 dc__gap-12 fs-14"
                                 onClick={handleOpenLicenseDialog}
+                                data-testid="about-devtron"
                             >
                                 <Icon name="ic-devtron" color="N600" size={20} />
                                 About Devtron

src/Shared/Components/LoginBanner/LoginBanner.tsx

@@ -1,5 +1,5 @@
 import { motion } from 'framer-motion'
-import { useEffect, useMemo, useState } from 'react'
+import { useEffect, useState } from 'react'
 import { Icon } from '../Icon'
 import { TESTIMONIAL_CARD_DATA, TESTIMONIAL_CARD_INTERVAL, TRANSITION_EASE_CURVE } from './constants'
 
@@ -98,17 +98,17 @@ const AnimatedBackground = () => (
 
 const LoginBanner = () => {
     const [currentIndex, setCurrentIndex] = useState<number>(0)
-    const testimonialCount = useMemo(() => TESTIMONIAL_CARD_DATA.length, [])
 
     useEffect(() => {
+        const testimonialCount = TESTIMONIAL_CARD_DATA.length
         const interval = setInterval(() => {
             setCurrentIndex((prevIndex) => (prevIndex + 1) % testimonialCount)
         }, TESTIMONIAL_CARD_INTERVAL)
 
         return () => {
             clearInterval(interval)
         }
-    }, [testimonialCount])
+    }, [])
 
     const { quote, name, designation, iconName } = TESTIMONIAL_CARD_DATA[currentIndex]
 

src/Shared/types.ts

@@ -1073,8 +1073,6 @@ export interface DevtronLicenseBaseDTO {
         domain: string | null
     } | null
     license: string | null
-    showLicenseData: boolean
-    licenseStatusError?: LicenseErrorStruct
 }
 
 export type DevtronLicenseDTO<isCentralDashboard extends boolean = false> = DevtronLicenseBaseDTO &
@@ -1085,9 +1083,13 @@ export type DevtronLicenseDTO<isCentralDashboard extends boolean = false> = Devt
                   lastName: string | null
                   email: string | null
               } | null
+              showLicenseData?: never
+              licenseStatusError?: never
           }
         : {
               claimedByUserDetails?: never
+              showLicenseData: boolean
+              licenseStatusError?: LicenseErrorStruct
           })
 
 export enum LicenseStatus {