feat: remove envId from params for scan v2 in image card

arunjaindev · arunjaindev · commit 1da1fdc342a9 · 2024-12-09T16:07:21.000+05:30
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@devtron-labs/devtron-fe-common-lib",
-    "version": "1.2.5",
+    "version": "1.2.5-beta-2",
     "description": "Supporting common component library",
     "type": "module",
     "main": "dist/index.js",
diff --git a/src/Shared/Components/ImageCardAccordion/types.ts b/src/Shared/Components/ImageCardAccordion/types.ts
@@ -29,7 +29,7 @@ export interface ImageCardAccordionProps extends MaterialSecurityInfoType {
     isScanEnabled: boolean
     SecurityModalSidebar: React.FC<SidebarPropsType>
     getSecurityScan: (
-        props: Pick<AppDetailsPayload, 'appId' | 'envId' | 'artifactId'>,
+        props: Pick<AppDetailsPayload, 'appId' | 'artifactId'>,
     ) => Promise<ResponseType<ApiResponseResultType>>
 }
 
diff --git a/src/Shared/Components/Security/Vulnerabilities/utils.ts b/src/Shared/Components/Security/Vulnerabilities/utils.ts
@@ -83,7 +83,7 @@ export const useGetSecurityVulnerabilities = ({
     )
 
     const [scanResultLoading, scanResultResponse, scanResultError, reloadScanResult] = useAsync(
-        () => getSecurityScan({ artifactId, appId, envId }),
+        () => getSecurityScan({ artifactId, appId }),
         [],
         isScanned && isScanEnabled && isScanV2Enabled && !!getSecurityScan,
         {

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@devtron-labs/devtron-fe-common-lib",`
`3`		`- "version": "1.2.5",`
	`3`	`+ "version": "1.2.5-beta-2",`
`4`	`4`	`"description": "Supporting common component library",`
`5`	`5`	`"type": "module",`
`6`	`6`	`"main": "dist/index.js",`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ export interface ImageCardAccordionProps extends MaterialSecurityInfoType {`
`29`	`29`	`isScanEnabled: boolean`
`30`	`30`	`SecurityModalSidebar: React.FC<SidebarPropsType>`
`31`	`31`	`getSecurityScan: (`
`32`		`- props: Pick<AppDetailsPayload, 'appId' \| 'envId' \| 'artifactId'>,`
	`32`	`+ props: Pick<AppDetailsPayload, 'appId' \| 'artifactId'>,`
`33`	`33`	`) => Promise<ResponseType<ApiResponseResultType>>`
`34`	`34`	`}`
`35`	`35`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ export const useGetSecurityVulnerabilities = ({`
`83`	`83`	`)`
`84`	`84`
`85`	`85`	`const [scanResultLoading, scanResultResponse, scanResultError, reloadScanResult] = useAsync(`
`86`		`- () => getSecurityScan({ artifactId, appId, envId }),`
	`86`	`+ () => getSecurityScan({ artifactId, appId }),`
`87`	`87`	`[],`
`88`	`88`	`isScanned && isScanEnabled && isScanV2Enabled && !!getSecurityScan,`
`89`	`89`	`{`