Merge pull request #769 from devtron-labs/feat/replace-conf-dialogs

feat: delete confirmation dialog

Author: arunjaindev

.eslintignore

@@ -21,7 +21,6 @@ src/Common/DebouncedSearch/DebouncedSearch.tsx
 src/Common/DebouncedSearch/Utils.ts
 src/Common/DebouncedSearch/__tests__/DebouncedSearch.test.tsx
 src/Common/DevtronProgressing/DevtronProgressing.tsx
-src/Common/Dialogs/ConfirmationDialog.tsx
 src/Common/Dialogs/DialogForm.tsx
 src/Common/DraggableWrapper/DraggableButton.tsx
 src/Common/DraggableWrapper/DraggableWrapper.tsx

package-lock.json

@@ -1,6 +1,6 @@
 {
     "name": "@devtron-labs/devtron-fe-common-lib",
-    "version": "1.15.0-pre-3",
+    "version": "1.15.0-pre-4",
     "description": "Supporting common component library",
     "type": "module",
     "main": "dist/index.js",

package.json

@@ -53,23 +53,7 @@ export interface ForceDeleteDialogType {
     forceDeleteDialogTitle: string
     forceDeleteDialogMessage: string
 }
-export interface ConfirmationDialogType {
-    className?: string
-    children: any
-    close?: (e) => void
-}
-export interface ConfirmationDialogIconType {
-    src: string
-    className?: string
-}
-export interface ConfirmationDialogBodyType {
-    title: string
-    subtitle?: ReactNode
-    children?: any
-}
-export interface ConfirmationDialogButtonGroupType {
-    children: any
-}
+
 export interface DialogFormProps {
     className: string
     title: string

src/Common/Dialogs/ConfirmationDialog.tsx

@@ -14,5 +14,4 @@
  * limitations under the License.
  */
 
-export { default as ConfirmationDialog } from './ConfirmationDialog'
 export * from './DialogForm'

src/Common/Dialogs/Types.ts

@@ -58,8 +58,7 @@ const ConfirmationModalBody = ({
     const hideIcon = variant === ConfirmationModalVariantType.custom && !ButtonIcon
 
     const disablePrimaryButton: boolean =
-        ('disabled' in primaryButtonConfig && primaryButtonConfig.disabled) ||
-        (confirmationKeyword && confirmationText.trim() !== confirmationKeyword)
+        !!primaryButtonConfig?.disabled || (confirmationKeyword && confirmationText.trim() !== confirmationKeyword)
 
     const handleTriggerPrimaryActionButton = () => {
         if (primaryButtonConfig && !disablePrimaryButton) {