code feedback incorporated

Author: shivani170

package-lock.json

@@ -1,6 +1,6 @@
 {
     "name": "@devtron-labs/devtron-fe-common-lib",
-    "version": "0.0.86-beta-6",
+    "version": "0.0.86-beta-7",
     "description": "Supporting common component library",
     "type": "module",
     "main": "dist/index.js",

package.json

@@ -31,4 +31,6 @@ export interface UseStateFiltersReturnType<T>
         | 'pageSize'
     > {}
 
-export interface PaginationType<T> extends Pick<UseUrlFiltersReturnType<T>, 'pageSize' | 'pageNumber'> {}
+export interface PaginationType<T> extends Pick<UseUrlFiltersReturnType<T>, 'pageSize'> {
+    pageNumber: number
+}

src/Common/Hooks/useStateFilters/types.ts

@@ -58,6 +58,7 @@ const useStateFilters = <T = string,>({
         setPagination({
             ...pagination,
             pageSize: _pageSize,
+            pageNumber: DEFAULT_PAGE_NUMBER,
         })
     }
 

src/Common/Hooks/useStateFilters/useStateFilters.tsx

@@ -32,10 +32,6 @@ export type UseUrlFiltersReturnType<T, K = unknown> = K & {
      * Currently applied page size
      */
     pageSize: number
-    /**
-     * PageNumber for the current page
-     */
-    pageNumber?: number
     /**
      * Handler for updating the current page
      */

src/Common/Hooks/useUrlFilters/types.ts

@@ -90,7 +90,7 @@ export const CommonGroupedDropdownStyles = {
         border: `1px solid var(--N200)`,
         borderRadius: `4px`,
         background: 'white',
-        height: '28px',
+        height: '24px',
         margin: '0px',
         padding: '2px',
         fontSize: '13px',