Skip to content

Commit 0754063

Browse files
committed
fix: review comments
1 parent d1e4182 commit 0754063

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

src/Assets/Icon/ic-failure.svg

Lines changed: 0 additions & 4 deletions
This file was deleted.

src/Shared/Components/CICDHistory/utils.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616
import { TIMELINE_STATUS } from '@Shared/constants'
1717
import { ReactComponent as ICAborted } from '@Icons/ic-aborted.svg'
18-
import { ReactComponent as ICFailure } from '@Icons/ic-failure.svg'
18+
import { ReactComponent as ICErrorCross } from '@Icons/ic-error-cross.svg'
1919
import {
2020
TriggerHistoryFilterCriteriaProps,
2121
DeploymentHistoryResultObject,
@@ -142,7 +142,9 @@ export const getStageStatusIcon = (status: StageStatusType): JSX.Element => {
142142
}
143143

144144
const renderAbortedTriggerIcon = (): JSX.Element => <ICAborted className="icon-dim-20 dc__no-shrink" />
145-
const renderFailedTriggerIcon = (): JSX.Element => <ICFailure className="icon-dim-20 dc__no-shrink" />
145+
const renderFailedTriggerIcon = (): JSX.Element => (
146+
<ICErrorCross className="icon-dim-20 dc__no-shrink ic-error-cross-red" />
147+
)
146148
const renderProgressingTriggerIcon = (): JSX.Element => (
147149
<ICInProgress className="dc__no-shrink icon-dim-20 ic-in-progress-orange" />
148150
)

src/Shared/constants.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ export const statusColor = {
401401
hibernating: 'var(--N700)',
402402
}
403403

404-
export const PULSATING_STATUS_MAP = {
404+
export const PULSATING_STATUS_MAP: { [key in keyof typeof statusColor]?: boolean } = {
405405
progressing: true,
406406
initiating: true,
407407
starting: true,

0 commit comments

Comments
 (0)