Skip to content

Commit 057936d

Browse files
authored
Merge pull request #289 from devtron-labs/feat/kubeconfig-rb
fix: dont use internal trigger if controlled from outside
2 parents 7940726 + a376987 commit 057936d

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@devtron-labs/devtron-fe-common-lib",
3-
"version": "0.2.17-patch-2",
3+
"version": "0.2.17-beta-4",
44
"description": "Supporting common component library",
55
"type": "module",
66
"main": "dist/index.js",

src/Common/ClipboardButton/ClipboardButton.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,16 @@ export default function ClipboardButton({
3434
content,
3535
copiedTippyText = 'Copied!',
3636
duration = 1000,
37-
trigger = false,
37+
trigger,
3838
setTrigger = noop,
3939
rootClassName = '',
4040
iconSize = 16,
4141
}: ClipboardProps) {
4242
const [copied, setCopied] = useState<boolean>(false)
4343
const [enableTippy, setEnableTippy] = useState<boolean>(false)
4444

45+
const isTriggerUndefined = typeof trigger === 'undefined'
46+
4547
const handleTextCopied = () => {setCopied(true)}
4648
const handleEnableTippy = () => setEnableTippy(true)
4749
const handleDisableTippy = () => setEnableTippy(false)
@@ -66,7 +68,7 @@ export default function ClipboardButton({
6668
}, [copied, duration, setTrigger])
6769

6870
useEffect(() => {
69-
if (trigger) {
71+
if (!isTriggerUndefined && trigger) {
7072
setCopied(true)
7173
handleCopyContent()
7274
}
@@ -84,7 +86,7 @@ export default function ClipboardButton({
8486
className={`dc__outline-none-imp p-0 flex dc__transparent--unstyled dc__no-border ${rootClassName}`}
8587
onMouseEnter={handleEnableTippy}
8688
onMouseLeave={handleDisableTippy}
87-
onClick={handleCopyContent}
89+
onClick={isTriggerUndefined && handleCopyContent}
8890
>
8991
{copied ? <Check className={iconClassName} /> : <ICCopy className={iconClassName} />}
9092
</button>

0 commit comments

Comments
 (0)