Launch configuration naming, tagging fix/clarity (terraform-aws-modules#11)

* remove unneeded concat of var.launch_configuration into name

when create_lc is set, it does not matter what var.launch_configuration
is set to, so dont concat it into aws_launch_configuration resource
generated name.

* add supplied tag blocks after name block so that all of the tags don't get rearranged every time one is added or removed.

Author: grimm26

main.tf

@@ -33,7 +33,7 @@ resource "aws_autoscaling_group" "this" {
   count = "${var.create_asg}"
 
   name_prefix          = "${coalesce(var.asg_name, var.name)}-"
-  launch_configuration = "${var.create_lc ? element(concat(aws_launch_configuration.this.*.id, list(var.launch_configuration)), 0) : var.launch_configuration}"
+  launch_configuration = "${var.create_lc ? element(aws_launch_configuration.this.*.name, 0) : var.launch_configuration}"
   vpc_zone_identifier  = ["${var.vpc_zone_identifier}"]
   max_size             = "${var.max_size}"
   min_size             = "${var.min_size}"
@@ -57,7 +57,7 @@ resource "aws_autoscaling_group" "this" {
   protect_from_scale_in     = "${var.protect_from_scale_in}"
 
   tags = ["${concat(
-      var.tags,
-      list(map("key", "Name", "value", var.name, "propagate_at_launch", true))
+      list(map("key", "Name", "value", var.name, "propagate_at_launch", true)),
+      var.tags
    )}"]
 }