Skip to content

Commit 57231c0

Browse files
author
Steven Nemetz
committed
Update readme. Add example refs to other modules
1 parent 6439477 commit 57231c0

File tree

4 files changed

+20
-4
lines changed

4 files changed

+20
-4
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Usage
1515

1616
```hcl
1717
module "asg" {
18-
source = "terraform-aws-modules/autoscaling/aws"
18+
source = "devops-workflow/autoscaling/aws"
1919
2020
name = "service"
2121

autoscaling-rules.tf

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,11 @@
1+
# TODO: Add mem alarms/policies - Look at ecs_cluster
2+
# Enable either one/both/none
3+
# Need something that will work well for ECS
4+
15
// CloudWatch Alarms
6+
# TODO: look at changing to a submodule
7+
# one module do high/low alarm and policies - Call for cpu, mem
8+
# ?? modules for single alarm and policy
29
resource "aws_cloudwatch_metric_alarm" "high_cpu" {
310
count = "${var.enable_scaling_policies}"
411
alarm_name = "${title("ec2-asg-${var.name}-high-cpu-utilization")}"
@@ -36,6 +43,7 @@ resource "aws_cloudwatch_metric_alarm" "low_cpu" {
3643
}
3744

3845
// Auto Scaling Policy
46+
# TODO: look at changing to a submodule
3947
resource "aws_autoscaling_policy" "cpu_scaling_out" {
4048
count = "${var.enable_scaling_policies}"
4149
name = "cpu-scaling-out"

examples/asg_disabled/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
Auto Scaling Group without ELB example
1+
Auto Scaling Group: Disabled
22
======================================
33

4-
Configuration in this directory creates Launch Configuration and Auto Scaling Group.
4+
Configuration in this directory run with the module disabled.
55

6-
Data sources are used to discover existing VPC resources (VPC, subnet and security group) as well as AMI details.
6+
The module should create nothing and not error on any of the outputs
77

88
Usage
99
=====

examples/other-modules/README.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# Other Terraform modules using this
2+
3+
List of other Terraform modules using this one that can also serve as more examples
4+
5+
6+
| Name | GitHub Repo | Terraform Registry |
7+
|-----|-----|-----|
8+
| ecs-cluster | [Repo](https://github.com/devops-workflow/terraform-aws-ecs-cluster) | [Registry]() |

0 commit comments

Comments
 (0)