Skip to content

Commit 4600be4

Browse files
authored
Fix wheels; fetch submodule (#61)
* Fix wheels; fetch submodule * skip windows for now
1 parent f48382c commit 4600be4

File tree

1 file changed

+39
-29
lines changed

1 file changed

+39
-29
lines changed

.github/workflows/python-wheels.yml

Lines changed: 39 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ jobs:
4444
manylinux: auto
4545
steps:
4646
- uses: actions/checkout@v4
47+
with:
48+
submodules: "recursive"
4749

4850
- name: Install uv
4951
uses: astral-sh/setup-uv@v5
@@ -82,6 +84,8 @@ jobs:
8284
target: armv7
8385
steps:
8486
- uses: actions/checkout@v4
87+
with:
88+
submodules: "recursive"
8589

8690
- name: Install uv
8791
uses: astral-sh/setup-uv@v5
@@ -105,34 +109,38 @@ jobs:
105109
name: wheels-musllinux-${{ matrix.platform.target }}
106110
path: dist
107111

108-
windows:
109-
runs-on: ${{ matrix.platform.runner }}
110-
strategy:
111-
matrix:
112-
platform:
113-
- runner: windows-latest
114-
target: x64
115-
steps:
116-
- uses: actions/checkout@v4
117-
# There seem to be linking errors on Windows with the uv-provided Python
118-
# executables, so we use the Python versions provided by github actions
119-
# for now.
120-
# Seems to be this question: https://stackoverflow.com/questions/78557803/python-with-rust-cannot-open-input-file-python3-lib
121-
- uses: actions/setup-python@v5
122-
with:
123-
python-version: 3.13
124-
architecture: ${{ matrix.platform.target }}
125-
- name: Build wheels
126-
uses: PyO3/maturin-action@v1
127-
with:
128-
target: ${{ matrix.platform.target }}
129-
args: --release --out dist -i 3.9 -i 3.10 -i 3.11 -i 3.12 -i 3.13 --manifest-path python/Cargo.toml
130-
sccache: "true"
131-
- name: Upload wheels
132-
uses: actions/upload-artifact@v4
133-
with:
134-
name: wheels-windows-${{ matrix.platform.target }}
135-
path: dist
112+
# We skip windows for now because the symlinks (for `pyi` typing) give "access denied" on windows.
113+
114+
# windows:
115+
# runs-on: ${{ matrix.platform.runner }}
116+
# strategy:
117+
# matrix:
118+
# platform:
119+
# - runner: windows-latest
120+
# target: x64
121+
# steps:
122+
# - uses: actions/checkout@v4
123+
# with:
124+
# submodules: "recursive"
125+
# # There seem to be linking errors on Windows with the uv-provided Python
126+
# # executables, so we use the Python versions provided by github actions
127+
# # for now.
128+
# # Seems to be this question: https://stackoverflow.com/questions/78557803/python-with-rust-cannot-open-input-file-python3-lib
129+
# - uses: actions/setup-python@v5
130+
# with:
131+
# python-version: 3.13
132+
# architecture: ${{ matrix.platform.target }}
133+
# - name: Build wheels
134+
# uses: PyO3/maturin-action@v1
135+
# with:
136+
# target: ${{ matrix.platform.target }}
137+
# args: --release --out dist -i 3.9 -i 3.10 -i 3.11 -i 3.12 -i 3.13 --manifest-path python/Cargo.toml
138+
# sccache: "true"
139+
# - name: Upload wheels
140+
# uses: actions/upload-artifact@v4
141+
# with:
142+
# name: wheels-windows-${{ matrix.platform.target }}
143+
# path: dist
136144

137145
macos:
138146
runs-on: ${{ matrix.platform.runner }}
@@ -145,6 +153,8 @@ jobs:
145153
target: aarch64
146154
steps:
147155
- uses: actions/checkout@v4
156+
with:
157+
submodules: "recursive"
148158

149159
- name: Install uv
150160
uses: astral-sh/setup-uv@v5
@@ -194,7 +204,7 @@ jobs:
194204
# # IMPORTANT: this permission is mandatory for trusted publishing
195205
# id-token: write
196206
if: startsWith(github.ref, 'refs/tags/')
197-
needs: [linux, musllinux, windows, macos]
207+
needs: [linux, musllinux, macos]
198208
steps:
199209
- uses: actions/download-artifact@v4
200210
with:

0 commit comments

Comments
 (0)