Skip to content

Commit ade5839

Browse files
committed
chore: Fix issues
1 parent 8957461 commit ade5839

File tree

8 files changed

+26
-67
lines changed

8 files changed

+26
-67
lines changed

lib/src/_generator_converger.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import 'package:df_gen_core/df_gen_core.dart';
1111
import 'package:df_log/df_log.dart';
1212
import 'package:df_config/df_config.dart';
13+
import 'package:df_string/df_string.dart';
1314

1415
import 'package:path/path.dart' as p;
1516

@@ -44,7 +45,8 @@ final generatorConverger = _GeneratorConverger(
4445
);
4546

4647
// Determine the output file path.
47-
final outputFilePath = p.join(replacement.insight.path, fileName);
48+
final folderName = replacement.insight.screenClassName.toSnakeCase();
49+
final outputFilePath = p.join(replacement.insight.path, folderName, fileName);
4850

4951
// Write the generated Dart file.
5052
await writeFile(outputFilePath, output);

lib/src/_insight.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ class Insight {
2020
final Map<String, String> internalParameters;
2121
final Set<String> queryParameters;
2222
final String path;
23-
final String makeup;
2423
final String title;
2524
final Set<String> partFileDirs;
2625

@@ -37,7 +36,6 @@ class Insight {
3736
required this.internalParameters,
3837
required this.queryParameters,
3938
required this.path,
40-
required this.makeup,
4139
required this.title,
4240
required this.partFileDirs,
4341
});

lib/src/_insight_mappers.dart

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,8 @@ final insightMappers = [
5757
_InsightMapper(
5858
placeholder: Placeholders.I1,
5959
mapInsights: (insight) async {
60-
final q1 = insight.queryParameters
61-
.map((e) => 'late final $e = this.configuration.$e;')
62-
.join('\n');
60+
final q1 =
61+
insight.queryParameters.map((e) => 'late final $e = this.configuration.$e;').join('\n');
6362
return q1;
6463
},
6564
),
@@ -83,18 +82,13 @@ final insightMappers = [
8382
final generateScreenBindingsArgs = [
8483
if (insight.path.isNotEmpty) "path: '${insight.path}'",
8584
if (insight.title.isNotEmpty) "defaultTitle: '${insight.title}'",
86-
if (insight.makeup.isNotEmpty) "makeup: '${insight.makeup}'",
87-
if (insight.isAccessibleOnlyIfLoggedIn)
88-
'isAccessibleOnlyIfLoggedIn: true',
85+
if (insight.isAccessibleOnlyIfLoggedIn) 'isAccessibleOnlyIfLoggedIn: true',
8986
if (insight.isAccessibleOnlyIfLoggedInAndVerified)
9087
'isAccessibleOnlyIfLoggedInAndVerified: true',
91-
if (insight.isAccessibleOnlyIfLoggedOut)
92-
'isAccessibleOnlyIfLoggedOut: true',
88+
if (insight.isAccessibleOnlyIfLoggedOut) 'isAccessibleOnlyIfLoggedOut: true',
9389
if (insight.isRedirectable) 'isRedirectable: true',
94-
if (insight.internalParameters.isNotEmpty && a.isNotEmpty)
95-
'internalParameters: {$a,}',
96-
if (insight.queryParameters.isNotEmpty && b.isNotEmpty)
97-
'queryParameters: {$b,}',
90+
if (insight.internalParameters.isNotEmpty && a.isNotEmpty) 'internalParameters: {$a,}',
91+
if (insight.queryParameters.isNotEmpty && b.isNotEmpty) 'queryParameters: {$b,}',
9892
].join(',');
9993
return generateScreenBindingsArgs;
10094
},

lib/src/generate_screen.dart

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ Future<void> generateScreen({
3232
bool isRedirectable = false,
3333
Map<String, String> internalParameters = const {},
3434
Set<String> queryParameters = const {},
35-
String makeup = '',
3635
String title = '',
3736
Set<String> partFileDirs = const {},
3837
}) async {
@@ -42,7 +41,7 @@ Future<void> generateScreen({
4241
final controllerTemplate = extractCodeFromMarkdown(
4342
await loadFileFromGitHub(
4443
username: 'robmllze',
45-
repo: 'df_generate_dart_models_core',
44+
repo: 'df_generate_screen',
4645
filePath: [
4746
controllerTemplateFilePath ?? 'templates/controller.dart.md',
4847
].join('/'),
@@ -52,7 +51,7 @@ Future<void> generateScreen({
5251
final screenTemplate = extractCodeFromMarkdown(
5352
await loadFileFromGitHub(
5453
username: 'robmllze',
55-
repo: 'df_generate_dart_models_core',
54+
repo: 'df_generate_screen',
5655
filePath: [
5756
screenTemplateFilePath ?? 'templates/screen.dart.md',
5857
].join('/'),
@@ -62,7 +61,7 @@ Future<void> generateScreen({
6261
final viewTemplate = extractCodeFromMarkdown(
6362
await loadFileFromGitHub(
6463
username: 'robmllze',
65-
repo: 'df_generate_dart_models_core',
64+
repo: 'df_generate_screen',
6665
filePath: [
6766
viewTemplateFilePath ?? 'templates/view.dart.md',
6867
].join('/'),
@@ -72,7 +71,7 @@ Future<void> generateScreen({
7271
final bindingsTemplate = extractCodeFromMarkdown(
7372
await loadFileFromGitHub(
7473
username: 'robmllze',
75-
repo: 'df_generate_dart_models_core',
74+
repo: 'df_generate_screen',
7675
filePath: [
7776
bindingsTemplateFilePath ?? 'templates/bindings.dart.md',
7877
].join('/'),
@@ -82,20 +81,18 @@ Future<void> generateScreen({
8281
final screenClassKey = screenName.toSnakeCase();
8382

8483
final insight = Insight(
85-
screenClassName: screenName.toSnakeCase(),
84+
screenClassName: screenName.toPascalCase(),
8685
bindingsFileName: '_bindings.g.dart',
8786
controllerFileName: '_controller.dart',
8887
screenFileName: '$screenClassKey.dart',
8988
viewFileName: '_view.dart',
9089
isAccessibleOnlyIfLoggedIn: isAccessibleOnlyIfLoggedIn,
91-
isAccessibleOnlyIfLoggedInAndVerified:
92-
isAccessibleOnlyIfLoggedInAndVerified,
90+
isAccessibleOnlyIfLoggedInAndVerified: isAccessibleOnlyIfLoggedInAndVerified,
9391
isAccessibleOnlyIfLoggedOut: isAccessibleOnlyIfLoggedOut,
9492
isRedirectable: isRedirectable,
9593
internalParameters: internalParameters,
9694
queryParameters: queryParameters,
9795
path: path,
98-
makeup: makeup,
9996
title: title,
10097
partFileDirs: partFileDirs,
10198
);

lib/src/run_generate_screens_app.dart

Lines changed: 6 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ Future<void> runGenerateScreensApp(List<String> args) async {
3535
)
3636
..addOption(
3737
'class-name',
38+
abbr: 'n',
3839
help: 'Screen name.',
3940
defaultsTo: 'ScreenExample',
4041
)
@@ -87,11 +88,6 @@ Future<void> runGenerateScreensApp(List<String> args) async {
8788
help: 'Is screen redirectable?',
8889
defaultsTo: false.toString(),
8990
)
90-
..addOption(
91-
'makeup',
92-
help: 'Screen makeup.',
93-
defaultsTo: '',
94-
)
9591
..addOption('default-title', help: 'Screen title.', defaultsTo: 'Title')
9692
..addOption(
9793
'part-file-dirs',
@@ -110,14 +106,11 @@ Future<void> runGenerateScreensApp(List<String> args) async {
110106
})
111107
.nonNulls
112108
.toSet();
113-
return entries != null
114-
? Map<String, String>.fromEntries(entries)
115-
: null;
109+
return entries != null ? Map<String, String>.fromEntries(entries) : null;
116110
}
117111

118112
bool toBool(String option) {
119-
return results[option]?.toString().toLowerCase().trim() ==
120-
true.toString();
113+
return results[option]?.toString().toLowerCase().trim() == true.toString();
121114
}
122115

123116
return _ArgsChecker(
@@ -136,7 +129,6 @@ Future<void> runGenerateScreensApp(List<String> args) async {
136129
isRedirectable: toBool('is-redirectable'),
137130
internalParameters: toOptionsMap('internal-parameters'),
138131
queryParameters: splitArg(results['query-parameters'])?.toSet(),
139-
makeup: results['makeup'],
140132
title: results['default-title'],
141133
partFileDirs: splitArg(results['part-file-dirs'])?.toSet(),
142134
);
@@ -152,13 +144,11 @@ Future<void> runGenerateScreensApp(List<String> args) async {
152144
viewTemplateFilePath: args.stateTemplateFilePath,
153145
path: args.path!,
154146
isAccessibleOnlyIfLoggedIn: args.isAccessibleOnlyIfLoggedIn ?? false,
155-
isAccessibleOnlyIfLoggedInAndVerified:
156-
args.isAccessibleOnlyIfLoggedInAndVerified ?? false,
147+
isAccessibleOnlyIfLoggedInAndVerified: args.isAccessibleOnlyIfLoggedInAndVerified ?? false,
157148
isAccessibleOnlyIfLoggedOut: args.isAccessibleOnlyIfLoggedOut ?? false,
158149
isRedirectable: args.isRedirectable ?? false,
159150
internalParameters: args.internalParameters ?? const {},
160151
queryParameters: args.queryParameters ?? const {},
161-
makeup: args.makeup ?? '',
162152
title: args.title ?? '',
163153
partFileDirs: args.partFileDirs ?? {},
164154
);
@@ -187,7 +177,6 @@ class _ArgsChecker extends ValidArgsChecker {
187177
final bool? isRedirectable;
188178
final Map<String, String>? internalParameters;
189179
final Set<String>? queryParameters;
190-
final String? makeup;
191180
final String? title;
192181
final Set<String>? partFileDirs;
193182

@@ -210,7 +199,6 @@ class _ArgsChecker extends ValidArgsChecker {
210199
required this.isRedirectable,
211200
required this.internalParameters,
212201
required this.queryParameters,
213-
required this.makeup,
214202
required this.title,
215203
required this.partFileDirs,
216204
});
@@ -227,14 +215,11 @@ class _ArgsChecker extends ValidArgsChecker {
227215
if (controllerTemplateFilePath != null) controllerTemplateFilePath,
228216
if (screenTemplateFilePath != null) screenTemplateFilePath,
229217
if (stateTemplateFilePath != null) stateTemplateFilePath,
230-
if (configurationTemplateFilePath != null)
231-
configurationTemplateFilePath,
232-
if (isAccessibleOnlyIfLoggedInAndVerified != null)
233-
isAccessibleOnlyIfLoggedInAndVerified,
218+
if (configurationTemplateFilePath != null) configurationTemplateFilePath,
219+
if (isAccessibleOnlyIfLoggedInAndVerified != null) isAccessibleOnlyIfLoggedInAndVerified,
234220
if (isAccessibleOnlyIfLoggedIn != null) isAccessibleOnlyIfLoggedIn,
235221
if (isAccessibleOnlyIfLoggedOut != null) isAccessibleOnlyIfLoggedOut,
236222
if (isRedirectable != null) isRedirectable,
237-
if (makeup != null) makeup,
238223
if (title != null) title,
239224
if (partFileDirs != null) partFileDirs,
240225
];

template/controller.dart.md

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ final class ___SCREEN_CLASS___Controller extends T___SCREEN_CLASS___Controller {
3030
3131
___Q1___
3232
___I1___
33-
final pCounter = Pod<int>(-1);
33+
final pCounter = Pod<int>(-1)..bindWith(this);
3434
3535
//
3636
//
@@ -49,17 +49,6 @@ final class ___SCREEN_CLASS___Controller extends T___SCREEN_CLASS___Controller {
4949
this.pCounter.set(0);
5050
super.initController();
5151
}
52-
53-
//
54-
//
55-
//
56-
57-
@override
58-
void dispose() {
59-
// Be sure to dispose all pods here.
60-
this.pCounter.dispose();
61-
super.dispose();
62-
}
6352
}
6453
6554
// ░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░

template/screen.dart.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
// ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓
99
//.title~
1010
11-
import '/_common.dart';
11+
import 'package:df_screen/df_screen.dart';
1212
1313
part '_bindings.g.dart';
1414
part '_controller.dart';

template/view.md

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,8 @@ final class _View extends T___SCREEN_CLASS___View {
1818
//
1919
2020
@override
21-
Widget top(BuildContext context) {
22-
return MyHeader(
23-
breadCrumbBar: MyBreadCrumbBar(
24-
routeManager: g.app.routeManager,
25-
),
26-
title: this.widget.configuration?.title,
27-
onBackButtonPressed: g.app.routeManager.goBack,
28-
);
21+
Widget topSide(BuildContext context, double topInsets) {
22+
return const SizedBox.shrink();
2923
}
3024
3125
//
@@ -56,7 +50,7 @@ final class _View extends T___SCREEN_CLASS___View {
5650
5751
@override
5852
Widget bottomSide(BuildContext context, double bottomInsets) {
59-
return bottomInsets == 0 ? const DcBottomNavigationControls() : const SizedBox();
53+
return const SizedBox.shrink();
6054
}
6155
}
6256

0 commit comments

Comments
 (0)