refactor url resirect (#3)

Author: cesargb

README.md

@@ -21,15 +21,12 @@ use Omnipay\Omnipay;
 
 $gateway = Omnipay::create('OfflineDummy');
 
-$gateway->initialize([
-    'url_notify' => 'http://example.com/payment/notify',
-    'url_return' => 'http://example.com/payment/return',
-]);
-
 $request = $gateway->purchase([
                 'amount' => '12.00',
                 'description' => 'Test purchase',
                 'transactionId' => 1,
+                'url_notify' => 'http://example.com/payment/notify',
+                'url_return' => 'http://example.com/payment/return',
             ])->send();
 
 $response->redirect();

resources/views/payment.blade.php

@@ -34,6 +34,8 @@
                 <form method="POST" action="/payment/process">
                     <input type="hidden" name="transition_id" value="{{ $transactionId }}" />
                     <input type="hidden" name="amount" value="{{ $amount }}" />
+                    <input type="hidden" name="url_notify" value="{{ $url_notify }}" />
+                    <input type="hidden" name="url_return" value="{{ $url_return }}" />
                     <input type="submit" name="status" value="{{ $label_success }}" />
                     <input type="submit" name="status" value="{{ $label_denied }}" />
                 </form>

src/App/Http/Controllers/PaymentController.php

@@ -20,6 +20,8 @@ public function __invoke(Request $request)
             'transactionId' => $request->input('transaction_id'),
             'description' => $request->input('description'),
             'amount' => $request->input('amount'),
+            'url_notify' => $request->input('url_notify'),
+            'url_return' => $request->input('url_return'),
             'label_success' => App::STATUS_SUCCESS,
             'label_denied' => App::STATUS_DENIED,
         ]);

src/App/Http/Controllers/PaymentProcessController.php

@@ -16,10 +16,10 @@ public function __invoke(Request $request)
         $response = $gateway->completePurchase($request->all())->send();
 
         Http::acceptJson()->post(
-            $gateway->getUrlNotify(),
+            $request->input('url_notify'),
             $response->getData()
         );
 
-        return response()->redirectTo($gateway->getUrlReturn());
+        return response()->redirectTo($request->input('url_return'));
     }
 }

src/Message/PurchaseRequest.php

@@ -35,13 +35,17 @@ public function getData()
         $this->validate(
             'amount',
             'description',
-            'transactionId'
+            'transactionId',
+            'url_notify',
+            'url_return',
         );
 
         return [
             'transaction_id' => $this->getTransactionId(),
             'amount' => $this->getAmount(),
             'description' => $this->getDescription(),
+            'url_notify' => $this->getUrlNotify(),
+            'url_return' => $this->getUrlReturn(),
         ];
     }
 

tests/AppTest.php

@@ -26,6 +26,8 @@ public function testPurchase()
                     'amount' => '12.00',
                     'description' => 'Test purchase',
                     'transactionId' => 1,
+                    'notify_url' => 'http://localhost:8080/gateway/notify',
+                    'url_return' => 'http://localhost:8080/gateway/return',
                 ]
             )->send();
 
@@ -45,13 +47,14 @@ public function testCompletePurchase()
             'transaction_id' => 1,
             'amount' => 12.00,
             'description' => 'Test purchase',
-            'notify_url' => 'http://localhost:8080/gateway/notify',
+            'url_notify' => 'http://localhost:8080/gateway/notify',
+            'url_return' => 'http://localhost:8080/gateway/return',
             'status' => App::STATUS_SUCCESS,
         ])->assertStatus(302)
-            ->assertRedirect($this->gateway->getUrlReturn());
+            ->assertRedirect('http://localhost:8080/gateway/return');
 
         Http::assertSent(function ($request) {
-            return $request->url() === $this->gateway->getUrlNotify();
+            return $request->url() === 'http://localhost:8080/gateway/notify';
         });
     }
 }