Skip to content

Commit 8092f36

Browse files
authored
Don't force inline slow_function_impl (#1016)
It created 2 copies of the function (normal one and one for metrics) Size benchmark from [`tree/objwrap_bench`](https://github.com/denoland/deno_core/tree/objwrap_bench) ``` 52M dcore_baseline 63M dcore_js 81M dcore_objwrap_old 68M dcore_objwrap_new ```
1 parent 56c88a8 commit 8092f36

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+0
-91
lines changed

ops/op2/dispatch_async.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,6 @@ pub(crate) fn generate_dispatch_async(
156156

157157
Ok(
158158
gs_quote!(generator_state(info, slow_function, slow_function_metrics, opctx) => {
159-
#[inline(always)]
160159
fn slow_function_impl<'s>(info: &'s deno_core::v8::FunctionCallbackInfo) -> usize {
161160
#[cfg(debug_assertions)]
162161
let _reentrancy_check_guard = deno_core::_ops::reentrancy_check(&<Self as deno_core::_ops::Op>::DECL);

ops/op2/dispatch_slow.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ pub(crate) fn generate_dispatch_slow(
142142

143143
Ok(
144144
gs_quote!(generator_state(opctx, info, slow_function, slow_function_metrics) => {
145-
#[inline(always)]
146145
fn slow_function_impl<'s>(#info: &'s deno_core::v8::FunctionCallbackInfo) -> usize {
147146
#[cfg(debug_assertions)]
148147
let _reentrancy_check_guard = deno_core::_ops::reentrancy_check(&<Self as deno_core::_ops::Op>::DECL);

ops/op2/test_cases/async/async_arg_return.out

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ops/op2/test_cases/async/async_arg_return_result.out

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ops/op2/test_cases/async/async_cppgc.out

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ops/op2/test_cases/async/async_deferred.out

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ops/op2/test_cases/async/async_jsbuffer.out

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ops/op2/test_cases/async/async_lazy.out

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ops/op2/test_cases/async/async_op_metadata.out

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ops/op2/test_cases/async/async_opstate.out

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)