Skip to content

Commit 59fbe7f

Browse files
authored
ci: pin nightly to 2025-01-02 (#1030)
Pin the nightly version for now. Starting from nightly 2025-01-03, all cfg(tests) produce compiler error: ``` error: unexpected `cfg` condition name: `test` --> ops/op2/mod.rs:363:7 | 363 | #[cfg(test)] | ^^^^ | = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `fmt_debug`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `ub_checks`, `unix`, and `windows` = help: consider using a Cargo feature instead = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [lints.rust] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(test)'] } = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(test)");` to the top of the `build.rs` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: `-D unexpected-cfgs` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unexpected_cfgs)]` ``` Seems related to rust-lang/rust#131729 and maybe some changes haven't propagated to cargo yet?
1 parent 726b802 commit 59fbe7f

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

.github/workflows/ci-lint-deps/action.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,13 @@ runs:
33
using: "composite"
44
steps:
55
- name: Install Rust (nightly)
6-
uses: dtolnay/rust-toolchain@nightly
6+
uses: dtolnay/rust-toolchain@master
7+
with:
8+
toolchain: nightly-2025-01-02
79
- name: Lint deps
810
shell: bash
911
run: |
1012
cargo install cargo-machete --locked
1113
cargo machete
1214
cargo install cargo-udeps --locked
13-
cargo +nightly udeps
15+
cargo +nightly-2025-01-02 udeps

.github/workflows/ci-test-miri/action.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,14 @@ runs:
33
using: "composite"
44
steps:
55
- name: Install Rust (nightly)
6-
uses: dtolnay/rust-toolchain@nightly
6+
uses: dtolnay/rust-toolchain@master
7+
with:
8+
toolchain: nightly-2025-01-02
79
- name: Cargo test (miri)
810
shell: bash
911
run: |
1012
# Install and run miri tests
1113
cargo clean
12-
rustup component add --toolchain nightly miri
14+
rustup component add --toolchain nightly-2025-01-02 miri
1315
# This somehow prints errors in CI that don't show up locally
14-
RUSTFLAGS=-Awarnings cargo +nightly miri test -p deno_core
16+
RUSTFLAGS=-Awarnings cargo +nightly-2025-01-02 miri test -p deno_core

0 commit comments

Comments
 (0)