Skip to content

Commit 3f15885

Browse files
authored
fix: update rusty_v8 (#886)
includes fixes for tla bugs introduced in 12.9
1 parent 2a56283 commit 3f15885

File tree

3 files changed

+16
-17
lines changed

3 files changed

+16
-17
lines changed

Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ deno_ops = { version = "0.182.0", path = "./ops" }
2424
serde_v8 = { version = "0.215.0", path = "./serde_v8" }
2525
deno_core_testing = { path = "./testing" }
2626

27-
v8 = { version = "0.104.0", default-features = false }
27+
v8 = { version = "0.105.0", default-features = false }
2828
deno_ast = { version = "=0.40.0", features = ["transpiling"] }
2929
deno_unsync = "0.4.0"
3030
deno_core_icudata = "0.0.73"

core/ops_builtin_v8.rs

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ struct SerializeDeserialize<'a> {
428428
impl<'a> v8::ValueSerializerImpl for SerializeDeserialize<'a> {
429429
#[allow(unused_variables)]
430430
fn throw_data_clone_error<'s>(
431-
&mut self,
431+
&self,
432432
scope: &mut v8::HandleScope<'s>,
433433
message: v8::Local<'s, v8::String>,
434434
) {
@@ -446,7 +446,7 @@ impl<'a> v8::ValueSerializerImpl for SerializeDeserialize<'a> {
446446
}
447447

448448
fn get_shared_array_buffer_id<'s>(
449-
&mut self,
449+
&self,
450450
scope: &mut v8::HandleScope<'s>,
451451
shared_array_buffer: v8::Local<'s, v8::SharedArrayBuffer>,
452452
) -> Option<u32> {
@@ -464,7 +464,7 @@ impl<'a> v8::ValueSerializerImpl for SerializeDeserialize<'a> {
464464
}
465465

466466
fn get_wasm_module_transfer_id(
467-
&mut self,
467+
&self,
468468
scope: &mut v8::HandleScope<'_>,
469469
module: v8::Local<v8::WasmModuleObject>,
470470
) -> Option<u32> {
@@ -484,12 +484,12 @@ impl<'a> v8::ValueSerializerImpl for SerializeDeserialize<'a> {
484484
}
485485
}
486486

487-
fn has_custom_host_object(&mut self, _isolate: &mut v8::Isolate) -> bool {
487+
fn has_custom_host_object(&self, _isolate: &mut v8::Isolate) -> bool {
488488
true
489489
}
490490

491491
fn is_host_object<'s>(
492-
&mut self,
492+
&self,
493493
scope: &mut v8::HandleScope<'s>,
494494
object: v8::Local<'s, v8::Object>,
495495
) -> Option<bool> {
@@ -502,10 +502,10 @@ impl<'a> v8::ValueSerializerImpl for SerializeDeserialize<'a> {
502502
}
503503

504504
fn write_host_object<'s>(
505-
&mut self,
505+
&self,
506506
scope: &mut v8::HandleScope<'s>,
507507
object: v8::Local<'s, v8::Object>,
508-
value_serializer: &mut dyn v8::ValueSerializerHelper,
508+
value_serializer: &dyn v8::ValueSerializerHelper,
509509
) -> Option<bool> {
510510
if let Some(host_objects) = self.host_objects {
511511
for i in 0..host_objects.length() {
@@ -524,7 +524,7 @@ impl<'a> v8::ValueSerializerImpl for SerializeDeserialize<'a> {
524524

525525
impl<'a> v8::ValueDeserializerImpl for SerializeDeserialize<'a> {
526526
fn get_shared_array_buffer_from_id<'s>(
527-
&mut self,
527+
&self,
528528
scope: &mut v8::HandleScope<'s>,
529529
transfer_id: u32,
530530
) -> Option<v8::Local<'s, v8::SharedArrayBuffer>> {
@@ -543,7 +543,7 @@ impl<'a> v8::ValueDeserializerImpl for SerializeDeserialize<'a> {
543543
}
544544

545545
fn get_wasm_module_from_id<'s>(
546-
&mut self,
546+
&self,
547547
scope: &mut v8::HandleScope<'s>,
548548
clone_id: u32,
549549
) -> Option<v8::Local<'s, v8::WasmModuleObject>> {
@@ -561,9 +561,9 @@ impl<'a> v8::ValueDeserializerImpl for SerializeDeserialize<'a> {
561561
}
562562

563563
fn read_host_object<'s>(
564-
&mut self,
564+
&self,
565565
scope: &mut v8::HandleScope<'s>,
566-
value_deserializer: &mut dyn v8::ValueDeserializerHelper,
566+
value_deserializer: &dyn v8::ValueDeserializerHelper,
567567
) -> Option<v8::Local<'s, v8::Object>> {
568568
if let Some(host_objects) = self.host_objects {
569569
let mut i = 0;
@@ -627,8 +627,7 @@ pub fn op_serialize(
627627
for_storage,
628628
host_object_brand,
629629
});
630-
let mut value_serializer =
631-
v8::ValueSerializer::new(scope, serialize_deserialize);
630+
let value_serializer = v8::ValueSerializer::new(scope, serialize_deserialize);
632631
value_serializer.write_header();
633632

634633
if let Some(transferred_array_buffers) = transferred_array_buffers {
@@ -707,7 +706,7 @@ pub fn op_deserialize<'a>(
707706
for_storage,
708707
host_object_brand: None,
709708
});
710-
let mut value_deserializer =
709+
let value_deserializer =
711710
v8::ValueDeserializer::new(scope, serialize_deserialize, &zero_copy);
712711
let parsed_header = value_deserializer
713712
.read_header(scope.get_current_context())

0 commit comments

Comments
 (0)