Create factory for IssueMaker. (#120)

Author: demiankatz

module/GeebyDeebyLocal/config/module.config.php

@@ -187,6 +187,7 @@
         'factories' => [
             'GeebyDeebyLocal\Ingest\DatabaseIngester' => 'GeebyDeebyLocal\Ingest\DatabaseIngesterFactory',
             'GeebyDeebyLocal\Ingest\FedoraHarvester' => 'GeebyDeebyLocal\Ingest\FedoraHarvesterFactory',
+            'GeebyDeebyLocal\Ingest\IssueMaker' => 'GeebyDeebyLocal\Ingest\IssueMakerFactory',
             'GeebyDeebyLocal\Ingest\SolrHarvester' => 'GeebyDeebyLocal\Ingest\SolrHarvesterFactory',
         ],
     ],

module/GeebyDeebyLocal/src/GeebyDeebyLocal/Command/Make/IssueCommandFactory.php

@@ -67,12 +67,8 @@ public function __invoke(
             throw new \Exception('Unexpected options sent to factory.');
         }
         $dbManager = $container->get(\GeebyDeeby\Db\Table\PluginManager::class);
-        $issueMaker = new IssueMaker(
-            $dbManager,
-            $container->get(\GeebyDeeby\Articles::class)
-        );
         return new $requestedName(
-            $issueMaker,
+            $container->get(IssueMaker::class),
             $dbManager->get('edition'),
             $dbManager->get('series')
         );

module/GeebyDeebyLocal/src/GeebyDeebyLocal/Command/Make/IssuesCommandFactory.php

@@ -67,10 +67,9 @@ public function __invoke(
             throw new \Exception('Unexpected options sent to factory.');
         }
         $dbManager = $container->get(\GeebyDeeby\Db\Table\PluginManager::class);
-        $issueMaker = new IssueMaker(
-            $dbManager,
-            $container->get(\GeebyDeeby\Articles::class)
+        return new $requestedName(
+            $container->get(IssueMaker::class),
+            $dbManager->get('series')
         );
-        return new $requestedName($issueMaker, $dbManager->get('series'));
     }
 }

module/GeebyDeebyLocal/src/GeebyDeebyLocal/Ingest/IssueMakerFactory.php

@@ -0,0 +1,74 @@
+<?php
+
+/**
+ * Factory for IssueMaker
+ *
+ * PHP version 7
+ *
+ * Copyright (C) Demian Katz 2025.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ *
+ * @category GeebyDeeby
+ * @package  Console
+ * @author   Demian Katz <demian.katz@villanova.edu>
+ * @license  http://opensource.org/licenses/gpl-2.0.php GNU General Public License
+ * @link     https://github.com/demiankatz/Geeby-Deeby Main Site
+ */
+
+namespace GeebyDeebyLocal\Ingest;
+
+use Interop\Container\ContainerInterface;
+use Laminas\ServiceManager\Factory\FactoryInterface;
+
+/**
+ * Factory for IssueMaker
+ *
+ * @category GeebyDeeby
+ * @package  Console
+ * @author   Demian Katz <demian.katz@villanova.edu>
+ * @license  http://opensource.org/licenses/gpl-2.0.php GNU General Public License
+ * @link     https://github.com/demiankatz/Geeby-Deeby Main Site
+ */
+class IssueMakerFactory implements FactoryInterface
+{
+    /**
+     * Create an object
+     *
+     * @param ContainerInterface $container     Service manager
+     * @param string             $requestedName Service being created
+     * @param null|array         $options       Extra options (optional)
+     *
+     * @return object
+     *
+     * @throws ServiceNotFoundException if unable to resolve the service.
+     * @throws ServiceNotCreatedException if an exception is raised when
+     * creating a service.
+     * @throws ContainerException if any other error occurs
+     */
+    public function __invoke(
+        ContainerInterface $container,
+        $requestedName,
+        array $options = null
+    ) {
+        if (!empty($options)) {
+            throw new \Exception('Unexpected options sent to factory.');
+        }
+        $dbManager = $container->get(\GeebyDeeby\Db\Table\PluginManager::class);
+        return new $requestedName(
+            $dbManager,
+            $container->get(\GeebyDeeby\Articles::class)
+        );
+    }
+}