Merge pull request #25 from Previnkumar-G/main

Workflow changes

Author: Jennifer-John

.github/workflows/ansible-test.yml

@@ -5,6 +5,8 @@ on:
     branches: [ main ]
   pull_request:
     branches: [ main ]
+  schedule:
+    - cron: '0 3 * * *'
 
 jobs:
   build:
@@ -35,10 +37,10 @@ jobs:
           name: collection
           path: .cache/collection-tarballs
 
-###
-# Unit tests (OPTIONAL)
-# 
-# https://docs.ansible.com/ansible/latest/dev_guide/testing_units.html
+  ###
+  # Unit tests (OPTIONAL)
+  # 
+  # https://docs.ansible.com/ansible/latest/dev_guide/testing_units.html
 
   unit:
     name: Unit Tests
@@ -47,8 +49,22 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: [3.8, 3.9]
-        ansible-version: [ stable-2.11, stable-2.12, stable-2.13]
+        python-version: ["3.8", "3.9", "3.10", "3.11"]
+        ansible-version: [stable-2.11, stable-2.12, stable-2.13, stable-2.14]
+        exclude:
+        # Python 3.11 is supported only from ansible-core 2.14 onwards
+        - python-version: "3.11"
+          ansible-version: stable-2.11
+        - python-version: "3.11"
+          ansible-version: stable-2.12
+        - python-version: "3.11"
+          ansible-version: stable-2.13
+        # Ansible-core 2.11 doesn't support python v3.10
+        - python-version: "3.10"
+          ansible-version: stable-2.11
+        # Ansible-core 2.14 supports only python versions 3.9, 3.10 and 3.11
+        - python-version: "3.8"
+          ansible-version: stable-2.14
 
     steps:
       - name: Set up Python ${{ matrix.python-version }}
@@ -75,18 +91,19 @@ jobs:
         run: ansible-test units -v --color --python ${{ matrix.python-version }} --coverage
         working-directory: /home/runner/.ansible/collections/ansible_collections/dellemc/unity
 
-###
-# Sanity tests (REQUIRED)
-#
-# https://docs.ansible.com/ansible/latest/dev_guide/testing_sanity.html
+  ###
+  # Sanity tests (REQUIRED)
+  #
+  # https://docs.ansible.com/ansible/latest/dev_guide/testing_sanity.html
 
   sanity:
     name: Sanity Tests
     runs-on: ubuntu-latest
     needs: [build]
     strategy:
+      fail-fast: false
       matrix:
-        ansible-version: [stable-2.11, stable-2.12, stable-2.13]
+        ansible-version: [stable-2.11, stable-2.12, stable-2.13, stable-2.14]
 
     steps:
       - name: Set up Python 3.9

plugins/modules/snapshotschedule.py

@@ -882,7 +882,7 @@ def perform_module_operation(self):
 
         if state == 'present' and type and schedule_details and\
                 len(schedule_details['rules']) == 1:
-            if(self.schedule_modify_required(schedule_details)):
+            if (self.schedule_modify_required(schedule_details)):
                 result['changed'] = self.modify_snapshot_schedule(
                     id, schedule_details)
 

tests/requirements.txt

@@ -2,5 +2,6 @@ pytest
 pytest-xdist
 pytest-mock
 pytest-cov
+pytest-forked
 coverage==4.5.4
 mock

tests/sanity/ignore-2.11.txt

@@ -20,4 +20,4 @@ plugins/modules/host.py import-2.6
 plugins/modules/host.py import-2.7
 plugins/modules/interface.py import-2.6
 plugins/modules/interface.py import-2.7
-plugins/modules/interface.py validate-modules:missing-gplv3-license
+plugins/modules/interface.py validate-modules:missing-gplv3-license

tests/sanity/ignore-2.14.txt

@@ -0,0 +1,19 @@
+plugins/modules/consistencygroup.py validate-modules:missing-gplv3-license
+plugins/modules/filesystem.py validate-modules:missing-gplv3-license
+plugins/modules/filesystem_snapshot.py validate-modules:missing-gplv3-license
+plugins/modules/info.py validate-modules:missing-gplv3-license
+plugins/modules/host.py validate-modules:missing-gplv3-license
+plugins/modules/nasserver.py validate-modules:missing-gplv3-license
+plugins/modules/nfs.py validate-modules:missing-gplv3-license
+plugins/modules/smbshare.py validate-modules:missing-gplv3-license
+plugins/modules/snapshot.py validate-modules:missing-gplv3-license
+plugins/modules/snapshotschedule.py validate-modules:missing-gplv3-license
+plugins/modules/storagepool.py validate-modules:missing-gplv3-license
+plugins/modules/tree_quota.py validate-modules:missing-gplv3-license
+plugins/modules/user_quota.py validate-modules:missing-gplv3-license
+plugins/modules/volume.py validate-modules:missing-gplv3-license
+plugins/modules/cifsserver.py validate-modules:missing-gplv3-license
+plugins/modules/nfsserver.py validate-modules:missing-gplv3-license
+plugins/modules/host.py import-2.7
+plugins/modules/interface.py import-2.7
+plugins/modules/interface.py validate-modules:missing-gplv3-license