XmlReader - ReadSubtree

[7H3LaughingMan]

I am just creating this issue to see if this is something you would be interested in. XmlReader has the ReadSubtree method which returns a new child reader that is meant for reading the current node and it's descendents while syncing with the parent reader. The one nice thing about this is that it prevents the child reader from going outside of the current node, which would be useful in case there are any major changes to the XML

For example if you take the below example and call ReadSubtree on <child> it will be impossible for the child reader to go past </child> and if something were to happen and it doesn't get to </child> when it's disposed it will move the parent reader to </child>.

<parent>
  <child>
    <item />
    <item />
    <item />
  </child>
</parent>

[dcronqvist]

Interesting, I've been meaning to check it out! After some experimenting it seems to work quite well, with the only downside that benchmarks show that we are allocating about 6% more memory, and taking about 6% longer time to parse (only for .tmx, comparing to current README benchmarks). It might be better to instead have extensive testing of the extension methods to make sure they behave as expected and throw on unexpected circumstances, rather than slowing down .tmx parsing. I'll look into it a bit more.

[7H3LaughingMan]

Interesting, didn't have a chance to check out the benchmarks but was something I was aware of and was interested if it might be of use.