XmlReader Extensions - XmlConvert

[7H3LaughingMan]

.NET provides the XmlConvert class for converting XML strings to proper .NET types, this seems like a better approach for parsing XML files since it already has built-in support for converting "1" or "true" to true and "0" or "false" to false. This would require changing some stuff around with the extension methods but it would prevent the need for trying to read a boolean attribute as an integer and checking the value. Doesn't change much other than readability and would prevent future problems like what happened with parsing attributes for TextObject.

If you are interested in something like this I can work on making a PR.

[7H3LaughingMan]

7H3LaughingMan@65d0d15

Here is a commit to a separate branch with what it would look like if you are interested.

[dcronqvist]

Interesting stuff! I think I personally prefer the clarity of parsing the expected stored type and then doing whatever operation that's needed to convert to the DotTiled model. If the file format really does store a 0 or 1, then it should be clear from the corresponding parsing method that we are expecting that kind of data in the actual xml.

However, I understand your idea and that we might have lessened the likelihood of certain problems, such as those fixed in #87, if we had done it this way - but the real problem there was my mistake of expecting an incorrect type. The solution to something like that should be to fix that expectation, instead of hiding that mistake behind some massaging of input values.