Skip to content

Commit 9799d87

Browse files
dcherianshoyer
andauthored
Apply suggestions from code review
Co-authored-by: Stephan Hoyer <shoyer@google.com>
1 parent 7b34077 commit 9799d87

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

xarray/util/generate_reductions.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ def {method}(
120120
]
121121
_NUMERIC_ONLY_NOTES = "Non-numeric variables will be removed prior to reducing."
122122

123-
extra_kwarg = collections.namedtuple("extra_kwarg", "docs kwarg call example")
123+
ExtraKwarg = collections.namedtuple("ExtraKwarg", "docs kwarg call example")
124124
skipna = extra_kwarg(
125125
docs=_SKIPNA_DOCSTRING,
126126
kwarg="skipna: bool = None,",
@@ -279,7 +279,8 @@ def generate_code(self, method):
279279
extra_kwargs = textwrap.indent("\n" + "\n".join(extra_kwargs), 12 * " ")
280280
else:
281281
extra_kwargs = ""
282-
return f""" return self.reduce(
282+
return f"""\
283+
return self.reduce(
283284
duck_array_ops.{method.array_method},
284285
dim=dim,{extra_kwargs}
285286
keep_attrs=keep_attrs,
@@ -310,7 +311,7 @@ class DataStructure:
310311
numeric_only: bool = False
311312

312313

313-
DatasetObject = DataStructure(
314+
DATASET_OBJECT = DataStructure(
314315
name="Dataset",
315316
docstring_create="""
316317
>>> ds = xr.Dataset(dict(da=da))
@@ -326,7 +327,7 @@ class DataStructure:
326327
numeric_only=False,
327328
)
328329

329-
DatasetGenerator = GenericReductionGenerator(
330+
DATASET_GENERATOR = GenericReductionGenerator(
330331
cls="",
331332
datastructure=DatasetObject,
332333
methods=REDUCTION_METHODS,

0 commit comments

Comments
 (0)